| Summary: | DFG should do its own static estimates of execution frequency before it starts creating OSR entrypoints | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | atrick, barraclough, bunhere, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, rakuco, sam, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 112840 | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2014-02-20 16:46:08 PST
Created attachment 224809 [details]
the patch
Attachment 224809 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:53: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 224809 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=224809&action=review r=me > Source/JavaScriptCore/ChangeLog:15 > + This is better than letting LLVM do its own static estimates, since by the time we > + generate LLVM IR, we may have messed up the CFG due to OSR entrypoint creation. Of > + course, it would be even better if we just slurped in some kind of execution counts > + from profiling, but we don't do that, yet. Do want. Landed in http://trac.webkit.org/changeset/164459 *** Bug 129055 has been marked as a duplicate of this bug. *** |