Summary: | check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, darin, gbalogh.u-szeged, glenn, llango.u-szeged, lvidacs.u-szeged, ossy, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
BJ Burg
2014-01-15 16:57:01 PST
The problem is that style-checker thinks if it is a part of a member initialization. similar problem occured in https://bugs.webkit.org/show_bug.cgi?id=128579 Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:239 ... ::glResolveMultisampleFramebufferAPPLE(); ... https://bugs.webkit.org/show_bug.cgi?id=127068 Source/WebKit/win/WebNodeHighlight.cpp:168: ... ::SelectObject(hdc.get(), hbmp.get()); ... Created attachment 224394 [details]
Patch
Comment on attachment 224394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224394&action=review > Tools/ChangeLog:8 > + Avoid match for :: Could you describe what the false positive was and what you're changing? This is too terse of a description. Created attachment 225315 [details]
Patch
Comment on attachment 225315 [details] Patch Clearing flags on attachment: 225315 Committed r164806: <http://trac.webkit.org/changeset/164806> All reviewed patches have been landed. Closing bug. *** Bug 126554 has been marked as a duplicate of this bug. *** |