Bug 126771
| Summary: | Web Inspector: use c++11 features in web-only agents | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | joepeck, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Blaze Burg
This has been annoying me. :)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/15794772>
Timothy Hatcher
Joe fixed InspectorAgent in bug 126763 when he moved it to JSC. No need to do that one, you will just conflict.
Blaze Burg
Joe is handling this when moving stuff around to JSC.
Joseph Pecoraro
Yes, as I've been moving code down into JSC I've been making it sparkle. So nullptr, unique_ptr, some references, better whitespace, etc.
There is plenty of code that code be updated in WebCore though. InstrumentingAgents, any WebCore agent (so not Runtime/Debugger). I'll happily review a patch making these changes.
Joseph Pecoraro
Another big one that is annoying me: OVERRIDE, FINAL
Joseph Pecoraro
Another big one that is annoying me: ASCIILiteral
Joseph Pecoraro
With Anders help I was about to get clang-modernize working. With that we can automate adding "override" where it is needed and using "nullptr".
It makes a bunch of changes:
Transform: AddOverride - Accepted: 1488
Transform: UseNullptr - Accepted: 267
Though I should first let Brian's more involved Reference change land first.
Joseph Pecoraro
Fixed nullptr and override with:
<https://webkit.org/b/127206> Modernize WebCore/inspector with override
<https://webkit.org/b/127303> Modernize WebCore/inspector with nullptr
Joseph Pecoraro
Pretty sure this is fixed, right? nullptr, override, final, lots of unique_ptr. We can file new bugs about other things (ASCIILiteral, References).