| Summary: | Web Inspector: use c++11 features in web-only agents | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> |
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | joepeck, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
BJ Burg
2014-01-10 12:18:05 PST
Joe fixed InspectorAgent in bug 126763 when he moved it to JSC. No need to do that one, you will just conflict. Joe is handling this when moving stuff around to JSC. Yes, as I've been moving code down into JSC I've been making it sparkle. So nullptr, unique_ptr, some references, better whitespace, etc. There is plenty of code that code be updated in WebCore though. InstrumentingAgents, any WebCore agent (so not Runtime/Debugger). I'll happily review a patch making these changes. Another big one that is annoying me: OVERRIDE, FINAL Another big one that is annoying me: ASCIILiteral With Anders help I was about to get clang-modernize working. With that we can automate adding "override" where it is needed and using "nullptr".
It makes a bunch of changes:
Transform: AddOverride - Accepted: 1488
Transform: UseNullptr - Accepted: 267
Though I should first let Brian's more involved Reference change land first.
Fixed nullptr and override with: <https://webkit.org/b/127206> Modernize WebCore/inspector with override <https://webkit.org/b/127303> Modernize WebCore/inspector with nullptr Pretty sure this is fixed, right? nullptr, override, final, lots of unique_ptr. We can file new bugs about other things (ASCIILiteral, References). |