Summary: | [WebGL2] Implement compressedTex{Sub}Image*, copyTexSubImage3D | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, noam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 126404, 209510 | ||||||
Attachments: |
|
Description
Dean Jackson
2014-01-03 12:13:04 PST
Also: void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, ArrayBufferView data); void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLsizei imageSize, ArrayBufferView data); Taking this as a follow-on to the other recent texture work. Changing synopsis to reflect functions being implemented under this bug. Created attachment 404287 [details]
Patch
Comment on attachment 404287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404287&action=review > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1311 > + synthesizeGLError( > + GraphicsContextGL::INVALID_OPERATION, "compressedTexImage2D", > + "a buffer is bound to PIXEL_UNPACK_BUFFER"); We typically wouldn't split this over lines, but it's ok. Committed r264377: <https://trac.webkit.org/changeset/264377> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404287 [details]. Comment on attachment 404287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404287&action=review >> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1311 >> + "a buffer is bound to PIXEL_UNPACK_BUFFER"); > > We typically wouldn't split this over lines, but it's ok. Understood - this was to make emacs' auto-indenting be compatible with WebKit's style. Otherwise it would auto-indent the second line to the open parenthesis, leading to a style error. |