Bug 121750

Summary: Add ExecState::uncheckedArgument and use where possible to shrink a bit
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dino, kondapallykalyan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 121758    
Bug Blocks:    
Attachments:
Description Flags
Patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion none

Description Darin Adler 2013-09-21 12:34:13 PDT
Add ExecState::uncheckedArgument and used it where possible to shrink code a bit
Comment 1 Darin Adler 2013-09-21 12:56:41 PDT
Created attachment 212280 [details]
Patch
Comment 2 Andreas Kling 2013-09-21 13:01:52 PDT
Comment on attachment 212280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212280&action=review

r=me buuuuut..

> Source/JavaScriptCore/interpreter/CallFrame.h:246
> +        JSValue uncheckedArgument(size_t argument)

We should merge this with getArgumentUnsafe().

> Source/WebCore/bridge/objc/objc_instance.mm:269
> -        for (unsigned i = 2; i < count ; i++) {
> +        for (unsigned i = 2; i < count; i++) {

No switching to prefix increment style?
Comment 3 Build Bot 2013-09-21 13:53:15 PDT
Comment on attachment 212280 [details]
Patch

Attachment 212280 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1907348

New failing tests:
fast/canvas/webgl/uniform-location.html
webgl/conformance/uniforms/null-uniform-location.html
webgl/conformance/misc/bad-arguments-test.html
webgl/conformance/uniforms/uniform-location.html
webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html
webgl/conformance/misc/null-object-behaviour.html
fast/canvas/webgl/null-uniform-location.html
webgl/conformance/state/gl-object-get-calls.html
fast/canvas/webgl/context-lost.html
fast/canvas/webgl/null-object-behaviour.html
fast/canvas/webgl/gl-object-get-calls.html
fast/canvas/webgl/bad-arguments-test.html
Comment 4 Build Bot 2013-09-21 13:53:17 PDT
Created attachment 212284 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-09-21 14:23:36 PDT
Comment on attachment 212280 [details]
Patch

Attachment 212280 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2053059

New failing tests:
fast/canvas/webgl/uniform-location.html
webgl/conformance/uniforms/null-uniform-location.html
webgl/conformance/misc/bad-arguments-test.html
webgl/conformance/uniforms/uniform-location.html
webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html
webgl/conformance/misc/null-object-behaviour.html
fast/canvas/webgl/null-uniform-location.html
webgl/conformance/state/gl-object-get-calls.html
fast/canvas/webgl/context-lost.html
fast/canvas/webgl/null-object-behaviour.html
fast/canvas/webgl/gl-object-get-calls.html
fast/canvas/webgl/bad-arguments-test.html
Comment 6 Build Bot 2013-09-21 14:23:38 PDT
Created attachment 212285 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2013-09-21 15:20:40 PDT
Comment on attachment 212280 [details]
Patch

Attachment 212280 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2033109

New failing tests:
fast/canvas/webgl/uniform-location.html
webgl/conformance/uniforms/null-uniform-location.html
webgl/conformance/misc/bad-arguments-test.html
webgl/conformance/uniforms/uniform-location.html
webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html
webgl/conformance/misc/null-object-behaviour.html
fast/canvas/webgl/null-uniform-location.html
webgl/conformance/state/gl-object-get-calls.html
fast/canvas/webgl/context-lost.html
fast/canvas/webgl/null-object-behaviour.html
fast/canvas/webgl/gl-object-get-calls.html
fast/canvas/webgl/bad-arguments-test.html
Comment 8 Build Bot 2013-09-21 15:20:42 PDT
Created attachment 212287 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Darin Adler 2013-09-21 21:01:48 PDT
Committed r156240: <http://trac.webkit.org/changeset/156240>
Comment 10 Alexey Proskuryakov 2013-09-21 23:15:41 PDT
This change broke multiple WebGL tests: <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156241%20(13150)/results.html>.
Comment 11 WebKit Commit Bot 2013-09-21 23:17:49 PDT
Re-opened since this is blocked by bug 121758
Comment 12 Darin Adler 2013-09-21 23:32:04 PDT
https://bugs.webkit.org/show_bug.cgi?id=121759 has the fixes for the WebGL failures
Comment 13 Alexey Proskuryakov 2013-09-22 00:06:47 PDT
There is also a failure in accessibility/accessibility-node-memory-management.html test. This is because the patch changes what's left on the stack in debug builds. Darin is going to add a setTimeout() before garbage collection to fix the test.