Bug 120715

Summary: Expected result images are sometimes blank in WKTR
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eflews.bot, gyuyoung.kim, rego+ews, rniwa, simon.fraser, thorton, webkit-ews, xan.lopez
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120843, 120847    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Fix the other platforms simon.fraser: review+

Description Simon Fraser (smfr) 2013-09-04 18:24:52 PDT
Expected result images are sometimes blank in WKTR
Comment 1 Simon Fraser (smfr) 2013-09-04 18:29:02 PDT
Created attachment 210534 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-09-04 18:29:30 PDT
<rdar://problem/14382142>
Comment 3 Early Warning System Bot 2013-09-04 18:45:10 PDT
Comment on attachment 210534 [details]
Patch

Attachment 210534 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1703017
Comment 4 Tim Horton 2013-09-04 19:17:32 PDT
Comment on attachment 210534 [details]
Patch

Seems reasonable to me, though I wonder if we shouldn't maybe do something cross-platform since everyone is doing this.
Comment 5 EFL EWS Bot 2013-09-04 19:28:15 PDT
Comment on attachment 210534 [details]
Patch

Attachment 210534 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1693808
Comment 6 Simon Fraser (smfr) 2013-09-05 11:49:46 PDT
Created attachment 210641 [details]
Fix the other platforms
Comment 7 Simon Fraser (smfr) 2013-09-05 12:34:47 PDT
Comment on attachment 210641 [details]
Fix the other platforms

Carry Tim's review forward.
Comment 8 Simon Fraser (smfr) 2013-09-05 12:38:08 PDT
https://trac.webkit.org/r155140
Comment 9 Ryosuke Niwa 2013-09-18 19:08:48 PDT
It seems like this patch caused media/video-object-fit.html to fail on Lion WK2 builders:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-object-fit.html
Comment 10 Alexey Proskuryakov 2013-09-18 22:33:00 PDT
media/video-object-fit.html is flaky everywhere.