| Summary: | [CSS Grid Layout] Add parsing for named grid lines | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
| Component: | CSS | Assignee: | Sergio Villar Senin <svillar> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | allan.jensen, andersca, buildbot, commit-queue, darin, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, kondapallykalyan, krit, macpherson, menard, rniwa, svillar, syoichi, webkit-ews | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 119756 | ||||||||
| Bug Blocks: | 103310, 119632 | ||||||||
| Attachments: |
|
||||||||
We added support for parsing named grid lines at <trac-list> level, i.e. in the definition of the grid. Now we should add support to parsing grid lines at <grid-line> level, i.e. inside grid-{row|column}-{start|end}. This change covers only the parsing, the layout changes are coming in a follow up patch. We should consider merging these two changes in Blink instead of starting from scratch: r150381 Add parsing for named grid lines This extends our grammar to support named grid lines (no support for named grid lines with 'span' yet, though the testing for that is added as part of this change). and r150587 Add parsing for named grid lines with 'span' This change extends our grammar to support all types of named grid lines (the current code would only support grid lines without the 'span' keyword). This means that grid-start: span 1 'first' will now be properly parsed (but not resolved for layout which will be done in a follow-up change).