Summary: | Rename <input type='color'> functions in WebPageProxy, WebColorPicker, | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ruth Fong <ruthiecftg> | ||||||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abecsi, bdakin, beidson, cmarcelo, commit-queue, jonlee, menard, ruthiecftg, thorton, webkit-bug-importer, webkit-ews | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 61276 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Ruth Fong
2013-07-25 11:33:26 PDT
Created attachment 207781 [details]
Patch
Comment on attachment 207781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207781&action=review > Source/WebKit2/ChangeLog:8 > + Renamed INPUT_TYPE_COLOR functions in UIProcess from ...colorChooser to ...colorPicker. Please put the justification for making the WK2 and WebCore names different here. Comment on attachment 207781 [details]
Patch
Sam r+'d this too.
Comment on attachment 207781 [details] Patch Attachment 207781 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1293484 Created attachment 207782 [details]
Patch
Comment on attachment 207782 [details] Patch Attachment 207782 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1289570 Created attachment 207784 [details]
Patch
Comment on attachment 207784 [details] Patch Attachment 207784 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1283761 Created attachment 207785 [details]
Patch
Comment on attachment 207785 [details] Patch Attachment 207785 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1287534 Created attachment 207787 [details]
Patch
Comment on attachment 207787 [details]
Patch
r+ assuming all the ports build
Comment on attachment 207787 [details] Patch Clearing flags on attachment: 207787 Committed r153504: <http://trac.webkit.org/changeset/153504> All reviewed patches have been landed. Closing bug. |