Bug 119094
| Summary: | Implement <input type='color'> for WK1 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ruth Fong <ruthiecftg> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bdakin, beidson, jonlee, mark.lam, ruthiecftg, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=148844 | ||
| Bug Depends on: | 61276 | ||
| Bug Blocks: | |||
Ruth Fong
Currently, INPUT_TYPE_COLOR is disabled. When the patch for bug 61276, INPUT_TYPE_COLOR will be enabled. For WK1, a stub implementation of WebChromeClient::createColorChooser will be added, but a real implementation of <input type='color'> should be added to WK1.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/14548980>
Mark Lam
Skipped fast/forms/color/input-color-onchange-event.html in r153552: <http://trac.webkit.org/changeset/153552>. The test will crash with an assertion failure on debug builds until this bug is fixed.
Please un-skip that test when this bug is fixed.
Mark Lam
(In reply to comment #2)
> Skipped fast/forms/color/input-color-onchange-event.html
I changed this to expect "Crash Pass" since it only crashes on debug builds, and still passes on release builds. Please remove this entry from the TestExpectation file when the bug is fixed.
Changed in r153554: <http://trac.webkit.org/changeset/153554>.
Alexey Proskuryakov
fast/forms/color/color-suggestion-picker-crash-on-set-value.html is another affected test.
Having an ASSERT_NOT_REACHED is a wrong way to not to not implement a feature, we should never assert on legitimate code paths.