Bug 118812

Summary:

Convert MathML fraction tests to reftests

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cfleizach, commit-queue, dbarton, gyuyoung.kim, rakuco, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

118599, 118601

Bug Blocks:

118853

Attachments:

Description	Flags
Patch V1	none
Patch V2	none
Patch V3	none

Frédéric Wang (:fredw)

Reported 2013-07-17 14:28:56 PDT

Follow-up of bug 118599.

Attachments
Patch V1 (219.89 KB, patch) 2013-07-17 14:34 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V2 (219.09 KB, patch) 2013-07-18 02:59 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V3 (219.10 KB, patch) 2013-07-18 09:49 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2013-07-17 14:34:58 PDT

Created attachment 206913 [details] Patch V1

Frédéric Wang (:fredw)

Comment 2 2013-07-18 02:59:02 PDT

Created attachment 206975 [details] Patch V2 Just refreshing the patch after the changes from bug 118601.

chris fleizach

Comment 3 2013-07-18 08:57:27 PDT

Comment on attachment 206975 [details] Patch V2 View in context: https://bugs.webkit.org/attachment.cgi?id=206975&action=review > LayoutTests/mathml/presentation/fractions-linethickness.html:13 > + <mfrac linethickness="thick"><mn>1</mn><mn>2</mn></mfrac> we should probably also test the subtler variations (veryverythin) in this test or another test so we have something that verifies the parsing > LayoutTests/mathml/presentation/fractions-mrow.html:9 > +  verifies <mrow> elements "can be" used as "the" num...

Frédéric Wang (:fredw)

Comment 4 2013-07-18 09:08:06 PDT

(In reply to comment #3) > (From update of attachment 206975 [details]) > we should probably also test the subtler variations (veryverythin) in this test or another test so we have something that verifies the parsing These three values ("thin", "medium", "thick") are specific to mfrac so I guess that's why a test was already written for them. The named spaces ("thickmathspace" etc) can be used for arbitrary lengths and the test "positive-namedspace.html" should already verify all these values for mspace@width. I don't think it's worth checking them for linethickness or other length attributes?

chris fleizach

Comment 5 2013-07-18 09:11:39 PDT

(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 206975 [details] [details]) > > we should probably also test the subtler variations (veryverythin) in this test or another test so we have something that verifies the parsing > > These three values ("thin", "medium", "thick") are specific to mfrac so I guess that's why a test was already written for them. The named spaces ("thickmathspace" etc) can be used for arbitrary lengths and the test "positive-namedspace.html" should already verify all these values for mspace@width. I don't think it's worth checking them for linethickness or other length attributes? Ok thanks. As long as they're tested elsewhere.

Frédéric Wang (:fredw)

Comment 6 2013-07-18 09:49:07 PDT

Created attachment 206998 [details] Patch V3

WebKit Commit Bot

Comment 7 2013-07-18 10:44:19 PDT

Comment on attachment 206998 [details] Patch V3 Clearing flags on attachment: 206998 Committed r152849: <http://trac.webkit.org/changeset/152849>

WebKit Commit Bot

Comment 8 2013-07-18 10:44:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.