Summary: | REGRESSION(r152235): 3 mspace tests failing on ML-WK2-Debug. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||
Component: | MathML | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, cfleizach, commit-queue, dbarton, esprehn+autocc, fred.wang, glenn, kling, mrobinson, rniwa, slewis, zalan | ||||||||||||
Priority: | P2 | Keywords: | Regression | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Andreas Kling
2013-07-02 05:48:56 PDT
The failing tests: mathml/presentation/mspace-units.html mathml/presentation/positive-namedspace.html mathml/presentation/mspace.html Committed r152287: <http://trac.webkit.org/changeset/152287> Skipped in r152287: <http://trac.webkit.org/changeset/152287> Frederic, have you looked at this one yet? (In reply to comment #4) > Frederic, have you looked at this one yet? Sorry, I didn't have time to look at that. I'm just doing a quick verification now and that seems to be something related to the "logical heights" that are not handle correctly (probably I should specify the mspace height). But these "logical heights" have caused problems in the past and I think Martin Robinson has a patch to remove the code that raise this assertion. I'll cc' you to the bug. bug 118601, comment 6 fixes the asserts. *** Bug 118813 has been marked as a duplicate of this bug. *** Created attachment 207060 [details]
Patch
Comment on attachment 207060 [details] Patch Attachment 207060 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1100699 New failing tests: mathml/presentation/mspace-units.html Created attachment 207063 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Created attachment 207074 [details]
Patch V2
So it seems the test for lengths is now failing on Mac. It didn't before the change to LayoutUnit (which is essentially using int instead of float). I'm trying to modify the computation to mimic what CSSPrimitiveValue does. Probably, the MathML parsing functions should be moved to CSSPrimitiveValue.cpp later so that they can call conversionToCanonicalUnitsScaleFactor.
Comment on attachment 207074 [details] Patch V2 Attachment 207074 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1101809 New failing tests: mathml/presentation/mspace-units.html Created attachment 207080 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Created attachment 207084 [details] Patch V3 OK so let's handle the Mac failure in bug 118900... Comment on attachment 207084 [details] Patch V3 Clearing flags on attachment: 207084 Committed r152902: <http://trac.webkit.org/changeset/152902> All reviewed patches have been landed. Closing bug. |