Bug 118298 – REGRESSION(r152235): 3 mspace tests failing on ML-WK2-Debug.

• Component: MathML
• Status: RESOLVED FIXED

[Andreas Kling]

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r152238%20(10863)/results.html

Example:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x00000001050fb85a WTFCrash + 42 (Assertions.cpp:339)
1   com.apple.WebCore             	0x00000001071abd1a WebCore::RenderMathMLBlock::preferredLogicalHeight() const + 74 (RenderMathMLBlock.h:74)
2   com.apple.WebCore             	0x00000001071ab017 WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing(WebCore::RenderObject*) + 55 (RenderMathMLBlock.cpp:121)
3   com.apple.WebCore             	0x00000001071b0fc6 WebCore::RenderMathMLRow::computePreferredLogicalWidths() + 294 (RenderMathMLRow.cpp:72)
4   com.apple.WebCore             	0x00000001071b128c WebCore::RenderMathMLRow::layout() + 60 (RenderMathMLRow.cpp:100)
5   com.apple.WebCore             	0x00000001063bed96 WebCore::RenderObject::layoutIfNeeded() + 54 (RenderObject.h:704)
6   com.apple.WebCore             	0x000000010701a4b3 WebCore::RenderBlock::layoutPositionedObjects(bool, bool) + 723 (RenderBlock.cpp:2914)
7   com.apple.WebCore             	0x0000000107017483 WebCore::RenderBlock::layoutBlock(bool, WebCore::LayoutUnit) + 2323 (RenderBlock.cpp:1695)
8   com.apple.WebCore             	0x000000010701636d WebCore::RenderBlock::layout() + 125 (RenderBlock.cpp:1432)
9   com.apple.WebCore             	0x00000001072d656d WebCore::RenderView::layoutContent(WebCore::LayoutState const&) + 93 (RenderView.cpp:143)
10  com.apple.WebCore             	0x00000001072d73b3 WebCore::RenderView::layout() + 1379 (RenderView.cpp:305)
11  com.apple.WebCore             	0x0000000106457aaf WebCore::FrameView::layout(bool) + 3167 (FrameView.cpp:1330)
12  com.apple.WebCore             	0x00000001061b94cf WebCore::Document::implicitClose() + 991 (Document.cpp:2455)
13  com.apple.WebCore             	0x000000010642e24b WebCore::FrameLoader::checkCallImplicitClose() + 155 (FrameLoader.cpp:844)
14  com.apple.WebCore             	0x000000010642dec6 WebCore::FrameLoader::checkCompleted() + 358 (FrameLoader.cpp:788)
15  com.apple.WebCore             	0x000000010642ca08 WebCore::FrameLoader::finishedParsing() + 184 (FrameLoader.cpp:721)
16  com.apple.WebCore             	0x00000001061c42cb WebCore::Document::finishedParsing() + 475 (Document.cpp:4417)
17  com.apple.WebCore             	0x000000010657f308 WebCore::HTMLConstructionSite::finishedParsing() + 24 (HTMLConstructionSite.cpp:349)
18  com.apple.WebCore             	0x000000010666eae4 WebCore::HTMLTreeBuilder::finished() + 116 (HTMLTreeBuilder.cpp:2926)
19  com.apple.WebCore             	0x000000010659ef1e WebCore::HTMLDocumentParser::end() + 174 (HTMLDocumentParser.cpp:757)
20  com.apple.WebCore             	0x000000010659da02 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() + 242 (HTMLDocumentParser.cpp:768)
21  com.apple.WebCore             	0x000000010659d82f WebCore::HTMLDocumentParser::prepareToStopParsing() + 271 (HTMLDocumentParser.cpp:212)
22  com.apple.WebCore             	0x000000010659ef73 WebCore::HTMLDocumentParser::attemptToEnd() + 67 (HTMLDocumentParser.cpp:780)
23  com.apple.WebCore             	0x000000010659efc8 WebCore::HTMLDocumentParser::finish() + 72 (HTMLDocumentParser.cpp:829)
24  com.apple.WebCore             	0x000000010622d5ba WebCore::DocumentWriter::end() + 346 (DocumentWriter.cpp:249)
25  com.apple.WebCore             	0x00000001061fe3d3 WebCore::DocumentLoader::finishedLoading(double) + 595 (DocumentLoader.cpp:403)
26  com.apple.WebCore             	0x00000001061fe0ee WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) + 270 (DocumentLoader.cpp:345)
27  com.apple.WebCore             	0x0000000105eaf35e WebCore::CachedResource::checkNotify() + 126 (CachedResource.cpp:369)
28  com.apple.WebCore             	0x0000000105eaf484 WebCore::CachedResource::finishLoading(WebCore::ResourceBuffer*) + 52 (CachedResource.cpp:386)
29  com.apple.WebCore             	0x0000000105ea95db WebCore::CachedRawResource::finishLoading(WebCore::ResourceBuffer*) + 187 (CachedRawResource.cpp:95)
30  com.apple.WebCore             	0x00000001074cd18b WebCore::SubresourceLoader::didFinishLoading(double) + 459 (SubresourceLoader.cpp:284)
31  com.apple.WebCore             	0x0000000107305cc5 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) + 53 (ResourceLoader.cpp:489)
32  com.apple.WebCore             	0x00000001076dbd4a -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] + 186 (WebCoreResourceHandleAsDelegate.mm:234)
33  com.apple.Foundation          	0x00007fff88826d88 __65-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:]_block_invoke_0 + 28
34  com.apple.Foundation          	0x00007fff88826ccc -[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:] + 227
35  com.apple.Foundation          	0x00007fff88826bc8 -[NSURLConnectionInternal _withActiveConnectionAndDelegate:] + 63
36  com.apple.CFNetwork           	0x00007fff86333091 ___delegate_didFinishLoading_block_invoke_0 + 40
37  com.apple.CFNetwork           	0x00007fff8632554a ___withDelegateAsync_block_invoke_0 + 90
38  com.apple.CFNetwork           	0x00007fff863b5f3a __block_global_1 + 28
39  com.apple.CoreFoundation      	0x00007fff8eb75154 CFArrayApplyFunction + 68
40  com.apple.CFNetwork           	0x00007fff863162b4 RunloopBlockContext::perform() + 124
41  com.apple.CFNetwork           	0x00007fff8631618b MultiplexerSource::perform() + 221
42  com.apple.CoreFoundation      	0x00007fff8eb56b31 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
43  com.apple.CoreFoundation      	0x00007fff8eb56455 __CFRunLoopDoSources0 + 245
44  com.apple.CoreFoundation      	0x00007fff8eb797f5 __CFRunLoopRun + 789
45  com.apple.CoreFoundation      	0x00007fff8eb790e2 CFRunLoopRunSpecific + 290
46  com.apple.HIToolbox           	0x00007fff842f8eb4 RunCurrentEventLoopInMode + 209
47  com.apple.HIToolbox           	0x00007fff842f8c52 ReceiveNextEventCommon + 356
48  com.apple.HIToolbox           	0x00007fff842f8ae3 BlockUntilNextEventMatchingListInMode + 62
49  com.apple.AppKit              	0x00007fff89c9c533 _DPSNextEvent + 685
50  com.apple.AppKit              	0x00007fff89c9bdf2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
51  com.apple.AppKit              	0x00007fff89c931a3 -[NSApplication run] + 517
52  com.apple.WebCore             	0x0000000107333e52 WebCore::RunLoop::run() + 114 (RunLoopMac.mm:44)
53  com.apple.WebKit2             	0x00000001037a853c int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebContentProcessMainDelegate>(int, char**) + 940 (ChildProcessEntryPoint.h:98)
54  com.apple.WebKit2             	0x00000001037a817b WebContentProcessMain + 27 (WebContentProcessMain.mm:179)
55  com.apple.WebProcess          	0x0000000103489d1d WebKit::BootstrapMain(int, char**) + 381
56  com.apple.WebProcess          	0x0000000103489b92 main + 34
57  libdyld.dylib                 	0x00007fff8582a7e1 start + 1

[Andreas Kling]

The failing tests:

mathml/presentation/mspace-units.html
mathml/presentation/positive-namedspace.html
mathml/presentation/mspace.html

[Andreas Kling]

Committed r152287: <http://trac.webkit.org/changeset/152287>

[Andreas Kling]

Skipped in r152287: <http://trac.webkit.org/changeset/152287>

[chris fleizach]

Frederic, have you looked at this one yet?

[Frédéric Wang (:fredw)]

(In reply to comment #4)
> Frederic, have you looked at this one yet?

Sorry, I didn't have time to look at that. I'm just doing a quick verification now and that seems to be something related to the "logical heights" that are not handle correctly (probably I should specify the mspace height). But these  "logical heights" have caused problems in the past and I think Martin Robinson has a patch to remove the code that raise this assertion. I'll cc' you to the bug.

[zalan]

bug 118601, comment 6 fixes the asserts.

[chris fleizach]

*** Bug 118813 has been marked as a duplicate of this bug. ***

[Frédéric Wang (:fredw)]

Created attachment 207060 [details]
Patch

[Build Bot]

Comment on attachment 207060 [details]
Patch

Attachment 207060 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1100699

New failing tests:
mathml/presentation/mspace-units.html

[Build Bot]

Created attachment 207063 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Frédéric Wang (:fredw)]

Created attachment 207074 [details]
Patch V2

So it seems the test for lengths is now failing on Mac. It didn't before the change to LayoutUnit (which is essentially using int instead of float). I'm trying to modify the computation to mimic what CSSPrimitiveValue does. Probably, the MathML parsing functions should be moved to CSSPrimitiveValue.cpp later so that they can call conversionToCanonicalUnitsScaleFactor.

[Build Bot]

Comment on attachment 207074 [details]
Patch V2

Attachment 207074 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1101809

New failing tests:
mathml/presentation/mspace-units.html

[Build Bot]

Created attachment 207080 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Frédéric Wang (:fredw)]

Created attachment 207084 [details]
Patch V3

OK so let's handle the Mac failure in bug 118900...

[WebKit Commit Bot]

Comment on attachment 207084 [details]
Patch V3

Clearing flags on attachment: 207084

Committed r152902: <http://trac.webkit.org/changeset/152902>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.