Bug 118014

Summary: Get rid of multiple inheritence for SVGViewElement interface
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, d-r, esprehn+autocc, fmalita, gyuyoung.kim, gyuyoung.kim, haraken, kling, koivisto, krit, pdr, rakuco, schenney, thorton, zimmermann
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118029, 118353    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2013-06-25 19:44:13 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/b6db991c6871d8ed29f3ec23028d38100be7e556 Get rid of multiple inheritence for SVGViewElement interface Web IDL no longer supports multiple inheritence. As per the latest specification SVGViewElement should only inherit from SVGElement. 'implements' statements are used for the rest. This patch refactors the IDL files to match the latest specification: http://www.w3.org/TR/SVG2/linking.html#InterfaceSVGViewElement Note that there is a WebExposed change as SVGZoomAndPan used to be exposed on the Window and it is not anymore. SVGZoomAndPan merely supplements SVGViewElement and should not be exposed to JavaScript according to the latest specification.
Attachments
Patch (25.92 KB, patch)
2013-06-25 23:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-06-25 23:47:41 PDT
Created attachment 205456 [details] Patch
Kentaro Hara
Comment 2 2013-06-25 23:51:23 PDT
Comment on attachment 205456 [details] Patch LGTM
WebKit Commit Bot
Comment 3 2013-06-26 03:40:24 PDT
Comment on attachment 205456 [details] Patch Clearing flags on attachment: 205456 Committed r151985: <http://trac.webkit.org/changeset/151985>
WebKit Commit Bot
Comment 4 2013-06-26 03:40:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.