Bug 116071

Summary:

Skipping {}, () and [] blocks while error recovering in CSS

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

CSS

Assignee:

Glenn Adams <glenn>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, dino, esprehn+autocc, glenn, kling, koivisto, macpherson, menard, svillar, syoichi, webkit-ews, zalan

Priority:

P2

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

116679, 117401, 117414, 117500

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Ryosuke Niwa

Reported 2013-05-13 16:11:17 PDT

We should probably merge https://chromium.googlesource.com/chromium/blink/+/711baebf836edc577d3157bfdfdbbb32a93da449 Skipping {}, () and [] blocks while error recovering in CSS. This affects recovering in expression, declaration and declaration lists.

Attachments
Patch (6.52 KB, patch) 2013-06-12 02:43 PDT, Sergio Villar Senin	no flags	Details Formatted Diff Diff
Patch (6.56 KB, patch) 2013-06-12 03:20 PDT, Sergio Villar Senin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Glenn Adams

Comment 1 2013-05-14 15:13:41 PDT

Also depends upon https://chromium.googlesource.com/chromium/blink/+/959863e444241eb36cff89d2c956676cd468bddf

Sergio Villar Senin

Comment 2 2013-06-12 02:43:21 PDT

Created attachment 204420 [details] Patch

Early Warning System Bot

Comment 3 2013-06-12 02:49:29 PDT

Comment on attachment 204420 [details] Patch Attachment 204420 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/790423

Early Warning System Bot

Comment 4 2013-06-12 02:51:09 PDT

Comment on attachment 204420 [details] Patch Attachment 204420 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/781236

Sergio Villar Senin

Comment 5 2013-06-12 02:55:00 PDT

Comment on attachment 204420 [details] Patch Need to attach a new version guarding CUEFUNCTION

Sergio Villar Senin

Comment 6 2013-06-12 03:20:35 PDT

Created attachment 204422 [details] Patch

Sergio Villar Senin

Comment 7 2013-06-12 10:23:50 PDT

Comment on attachment 204422 [details] Patch Clearing flags on attachment: 204422 Committed r151510: <http://trac.webkit.org/changeset/151510>

Sergio Villar Senin

Comment 8 2013-06-12 10:24:04 PDT

All reviewed patches have been landed. Closing bug.

alan

Comment 9 2013-07-01 12:16:06 PDT

This caused a regression: https://bugs.webkit.org/show_bug.cgi?id=118260

Note You need to log in before you can comment on or make changes to this bug.