Bug 116071

Summary: Skipping {}, () and [] blocks while error recovering in CSS
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Glenn Adams <glenn>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dino, esprehn+autocc, glenn, kling, koivisto, macpherson, menard, svillar, syoichi, webkit-ews, zalan
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116679, 117401, 117414, 117500    
Bug Blocks: 116678    
Attachments:
Description Flags
Patch
none
Patch none

Description Ryosuke Niwa 2013-05-13 16:11:17 PDT
We should probably merge
https://chromium.googlesource.com/chromium/blink/+/711baebf836edc577d3157bfdfdbbb32a93da449


Skipping {}, () and [] blocks while error recovering in CSS.

This affects recovering in expression, declaration and declaration lists.
Comment 2 Sergio Villar Senin 2013-06-12 02:43:21 PDT
Created attachment 204420 [details]
Patch
Comment 3 Early Warning System Bot 2013-06-12 02:49:29 PDT
Comment on attachment 204420 [details]
Patch

Attachment 204420 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/790423
Comment 4 Early Warning System Bot 2013-06-12 02:51:09 PDT
Comment on attachment 204420 [details]
Patch

Attachment 204420 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/781236
Comment 5 Sergio Villar Senin 2013-06-12 02:55:00 PDT
Comment on attachment 204420 [details]
Patch

Need to attach a new version guarding CUEFUNCTION
Comment 6 Sergio Villar Senin 2013-06-12 03:20:35 PDT
Created attachment 204422 [details]
Patch
Comment 7 Sergio Villar Senin 2013-06-12 10:23:50 PDT
Comment on attachment 204422 [details]
Patch

Clearing flags on attachment: 204422

Committed r151510: <http://trac.webkit.org/changeset/151510>
Comment 8 Sergio Villar Senin 2013-06-12 10:24:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 zalan 2013-07-01 12:16:06 PDT
This caused a regression: https://bugs.webkit.org/show_bug.cgi?id=118260