Bug 116678 - CSS Variables tokenisation not checking CSS identifier length
Summary: CSS Variables tokenisation not checking CSS identifier length
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: BlinkMergeCandidate
Depends on: 116071
  Show dependency treegraph
Reported: 2013-05-23 08:38 PDT by Sergio Villar Senin
Modified: 2013-06-12 09:38 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-05-23 08:38:57 PDT
We should consider merging this change https://codereview.chromium.org/15317009 and the test case which is not currently in WebKit.
Comment 1 Sergio Villar Senin 2013-06-12 09:38:41 PDT
There is no need to merge this fix. The ASSERT() was triggered because the code was using isEqualToCSSIdentifier() which had some restrictions not applicable to the CSS variables case. Actually the ASSERT() mentioned in the Chromium bug can no longer happen since r150776, as we perform a case sensitive check in a different inline method which does not have those assertions.