Bug 116679 - Refactoring CSS grammar
Summary: Refactoring CSS grammar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
Depends on: 115709
Blocks: 116071
  Show dependency tree / graph
 
Reported: 2013-05-23 09:00 PDT by Sergio Villar Senin
Modified: 2013-05-28 07:37 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2013-05-28 03:36 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-05-23 09:00:39 PDT 
We should probably merge
https://chromium.googlesource.com/chromium/blink/+/959863e444241eb36cff89d2c956676cd468bddf

Nonfunctional change.
Introduced closing_parenthesis and error_recovery to reduce code duplication.

Extracted from https://codereview.chromium.org/14969002/
Comment 1 Sergio Villar Senin 2013-05-23 09:40:21 PDT 
Which seems to depend on https://codereview.chromium.org/14083017.
Comment 2 Sergio Villar Senin 2013-05-28 03:36:52 PDT 
Created attachment 203036 [details]
Patch
Comment 3 Sergio Villar Senin 2013-05-28 07:37:25 PDT 
Comment on attachment 203036 [details]
Patch

Clearing flags on attachment: 203036

Committed r150804: <http://trac.webkit.org/changeset/150804>
Comment 4 Sergio Villar Senin 2013-05-28 07:37:32 PDT 
All reviewed patches have been landed.  Closing bug.