Bug 117414 - Autoclose braces and parentheses at the end of style sheet
Summary: Autoclose braces and parentheses at the end of style sheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
Depends on: 117401
Blocks: 116071
  Show dependency tree / graph
 
Reported: 2013-06-10 10:23 PDT by Sergio Villar Senin
Modified: 2013-06-11 00:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.03 KB, patch)
2013-06-10 10:36 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-06-10 10:23:48 PDT 
We should consider merging:

https://src.chromium.org/viewvc/blink?view=rev&revision=150202
Autoclosing braces and parentheses at TOKEN_EOF in CSS grammar.

It's consistent with the spec http://www.w3.org/TR/CSS21/syndata.html#parsing-errors which mentions that: "User agents must close all open constructs (for example: blocks, parentheses, brackets, rules, strings, and comments) at the end of the style sheet"
Comment 1 Sergio Villar Senin 2013-06-10 10:36:51 PDT 
Created attachment 204174 [details]
Patch
Comment 2 Andreas Kling 2013-06-10 14:41:49 PDT 
Comment on attachment 204174 [details]
Patch

Good pick.
r=me
Comment 3 Sergio Villar Senin 2013-06-11 00:10:13 PDT 
Comment on attachment 204174 [details]
Patch

Clearing flags on attachment: 204174

Committed r151424: <http://trac.webkit.org/changeset/151424>
Comment 4 Sergio Villar Senin 2013-06-11 00:10:19 PDT 
All reviewed patches have been landed.  Closing bug.