| Summary: | [Qt] CSS Exclusions feature is enabled in DRT, but not in QtTestBrowser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||
| Component: | WebKit Qt | Assignee: | Zoltan Horvath <zoltan> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | abecsi, allan.jensen, hausmann, kling, vestbo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 57311 | ||||||
| Attachments: |
|
||||||
|
Description
Zoltan Horvath
2013-05-09 09:56:03 PDT
Created attachment 201246 [details]
proposed patch
Comment on attachment 201246 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review > Source/WebKit/qt/Api/qwebsettings.h:82 > + CSSExclusionsEnabled, I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility. (In reply to comment #2) > (From update of attachment 201246 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review > > > Source/WebKit/qt/Api/qwebsettings.h:82 > > + CSSExclusionsEnabled, > > I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility. I don't want to break any compatibility. Do you know any way how to add this settings as a private setting? Comment on attachment 201246 [details] proposed patch We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug. (In reply to comment #4) > (From update of attachment 201246 [details]) > We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug. I very much like that approach :) |