Bug 115720

Summary: [GTK][WK2] Add the WebKitBatteryProvider class
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115718, 115719    
Bug Blocks: 95582, 125453    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch mrobinson: review+

Zan Dobersek
Reported 2013-05-07 03:37:19 PDT
[GTK][WK2] Add the WebKitBatteryProvider class
Attachments
Patch (12.43 KB, patch)
2013-05-07 03:57 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (12.38 KB, patch)
2013-05-15 01:15 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (12.36 KB, patch)
2013-11-06 04:06 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (12.36 KB, patch)
2013-12-09 07:34 PST, Zan Dobersek 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-05-07 03:57:32 PDT
Created attachment 200889 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-07 03:58:36 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2013-05-07 08:17:48 PDT
Perhaps we should share the EFL implementation for the moment?
Zan Dobersek
Comment 4 2013-05-15 01:15:07 PDT
Created attachment 201801 [details] Patch
Zan Dobersek
Comment 5 2013-11-06 04:06:25 PST
Created attachment 216162 [details] Patch Rebased patch.
Zan Dobersek
Comment 6 2013-12-09 07:34:34 PST
Created attachment 218761 [details] Patch Rebased patch.
Martin Robinson
Comment 7 2013-12-11 06:31:03 PST
Comment on attachment 218761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218761&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitBatteryProvider.cpp:83 > +void WebKitBatteryProvider::updateBatteryStatus(WebCore::BatteryProviderUPowerStatus status, double timeRemaining, double level) timeRemaining to something like secondsRemaining perhaps?
Zan Dobersek
Comment 8 2013-12-11 10:19:59 PST
Committed r160445: <http://trac.webkit.org/changeset/160445>
Note You need to log in before you can comment on or make changes to this bug.