Bug 115511

Summary:

[Qt] REGRESSION(r149457): some fast/exclusions tests are failing

Product:

WebKit

Reporter:

Zoltan Arvai <zarvai>

Component:

Tools / Tests

Assignee:

Hans Muller <giles_joplin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, giles_joplin, jturcotte, kadam, krit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79666, 115455

Attachments:

Description	Flags
Patch	kling: review-
Patch	none

Description Zoltan Arvai 2013-05-02 04:35:37 PDT

Four test failing on Qt:

fast/exclusions/shape-inside/shape-inside-polygon-layout.html
fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

On Qt sub-pixel layout is enabled (except Qt Mac).

Comment 1 Zoltan Arvai 2013-05-02 05:14:00 PDT

Skipped on Qt in http://trac.webkit.org/changeset/149484.
Please unskip it when it fixed.

Comment 2 Hans Muller 2013-05-17 16:10:08 PDT

Created attachment 202170 [details]
Patch

Unskipping the exclusions tests.  There were fixed by https://bugs.webkit.org/show_bug.cgi?id=116115.  Thanks for Zoltan Horvath for checking the patch against a Qt build.

Comment 3 Andreas Kling 2013-05-17 16:16:27 PDT

Comment on attachment 202170 [details]
Patch

Needs more ChangeLog.

Comment 4 Hans Muller 2013-05-20 08:19:46 PDT

Created attachment 202278 [details]
Patch

Added the ChangeLog (sorry about that).  

This bug's ID# is a palindrome.

Comment 5 WebKit Commit Bot 2013-05-20 13:00:29 PDT

Comment on attachment 202278 [details]
Patch

Clearing flags on attachment: 202278

Committed r150378: <http://trac.webkit.org/changeset/150378>

Comment 6 WebKit Commit Bot 2013-05-20 13:00:32 PDT

All reviewed patches have been landed.  Closing bug.