Bug 115511 - [Qt] REGRESSION(r149457): some fast/exclusions tests are failing
Summary: [Qt] REGRESSION(r149457): some fast/exclusions tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 79666 115455
  Show dependency tree / graph
 
Reported: 2013-05-02 04:35 PDT by Zoltan Arvai
Modified: 2013-05-20 13:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (970 bytes, patch)
2013-05-17 16:10 PDT, Hans Muller 		kling: review-
Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2013-05-20 08:19 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2013-05-02 04:35:37 PDT 
Four test failing on Qt:

fast/exclusions/shape-inside/shape-inside-polygon-layout.html
fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

On Qt sub-pixel layout is enabled (except Qt Mac).
Comment 1 Zoltan Arvai 2013-05-02 05:14:00 PDT 
Skipped on Qt in http://trac.webkit.org/changeset/149484.
Please unskip it when it fixed.
Comment 2 Hans Muller 2013-05-17 16:10:08 PDT 
Created attachment 202170 [details]
Patch

Unskipping the exclusions tests.  There were fixed by https://bugs.webkit.org/show_bug.cgi?id=116115.  Thanks for Zoltan Horvath for checking the patch against a Qt build.
Comment 3 Andreas Kling 2013-05-17 16:16:27 PDT 
Comment on attachment 202170 [details]
Patch

Needs more ChangeLog.
Comment 4 Hans Muller 2013-05-20 08:19:46 PDT 
Created attachment 202278 [details]
Patch

Added the ChangeLog (sorry about that).  

This bug's ID# is a palindrome.
Comment 5 WebKit Commit Bot 2013-05-20 13:00:29 PDT 
Comment on attachment 202278 [details]
Patch

Clearing flags on attachment: 202278

Committed r150378: <http://trac.webkit.org/changeset/150378>
Comment 6 WebKit Commit Bot 2013-05-20 13:00:32 PDT 
All reviewed patches have been landed.  Closing bug.