Bug 116115 - [CSS Exclusions] Some layout tests fail to account for inline pixel snapping
Summary: [CSS Exclusions] Some layout tests fail to account for inline pixel snapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 115292
  Show dependency treegraph
 
Reported: 2013-05-14 12:09 PDT by Hans Muller
Modified: 2013-05-14 19:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.10 KB, patch)
2013-05-14 14:51 PDT, Hans Muller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-05-14 12:09:31 PDT
Inline layout snaps boxes' logical top and bottom to pixels and line segment layout rounds the logical left and floors the logical right of segments.  The following exclusions tests did not take this into account:

shape-inside/shape-inside-polygon-layout.html
shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html 
shape-outside-floats/shape-outside-floats-ellipse-margin-left.html
shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

This patch reflects changes included in https://code.google.com/p/chromium/issues/detail?id=237568
Comment 1 Hans Muller 2013-05-14 14:51:29 PDT
Created attachment 201762 [details]
Patch
Comment 2 Dirk Schulze 2013-05-14 16:17:36 PDT
Comment on attachment 201762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201762&action=review

r=me.

> LayoutTests/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:73
> +    return String( Math.floor(f) );

I don not really like the spaces, but do not care that much about them.
Comment 3 WebKit Commit Bot 2013-05-14 19:17:19 PDT
Comment on attachment 201762 [details]
Patch

Clearing flags on attachment: 201762

Committed r150097: <http://trac.webkit.org/changeset/150097>
Comment 4 WebKit Commit Bot 2013-05-14 19:17:20 PDT
All reviewed patches have been landed.  Closing bug.