Summary: | [EFL][Qt] Three inspector test are failing after r146840 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ádám Kallai <kadam> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | d-r, oliver, ossy, szledan, timothy, webkit.review.bot, zarvai | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 65829 | ||||||
Bug Blocks: | 79666 | ||||||
Attachments: |
|
Description
Ádám Kallai
2013-03-26 03:22:35 PDT
These results just need added to the platform expectations. They are correct. Thanks for your quick response. I will add new baseline to Qt. Added platform specific expected files in: http://trac.webkit.org/changeset/146876 I'm against adding 3 same expected file (Mac/EFL/Qt) for one test. It seems it is JSC/V8 related problem. As far as I remember there was a consensus that in this case the platform independent result should be the JSC specific result and the V8 specific should be in platform-chromium. inspector/console/console-eval-syntax-error.html still have chromium specific result, and its platform independent result is unused now, so it should be updated for JSC platforms. inspector/debugger/debugger-pause-in-eval-script.html and inspector/extensions/extensions-eval.html don't have chromium specific expected file now. Makes sense to me. JSC is in WebKit, V8 isn't. Created attachment 195089 [details]
proposed patch
I uploaded a patch for the problem. Ossy thanks for your help. :)
Comment on attachment 195089 [details]
proposed patch
r=me, but let's see if the Mac and the Chromium EWS is happy before landing.
Comment on attachment 195089 [details]
proposed patch
EWS bots are green, let's land it.
Comment on attachment 195089 [details] proposed patch Clearing flags on attachment: 195089 Committed r147083: <http://trac.webkit.org/changeset/147083> All reviewed patches have been landed. Closing bug. |