Bug 112389

Summary: [CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 103314    
Attachments:
Description Flags
Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated.
none
Patch for landing none

Julien Chaffraix
Reported 2013-03-14 16:24:28 PDT
After bug 112299 and bug 112211, the code is in a state where we can easily implement the layout of the specification algorithm. This bug will only implement the layout side of this, the preferred / implicit logical widths bits are deferred to bug 112388 as they need more thinking.
Attachments
Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated. (24.18 KB, patch)
2013-03-14 16:33 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch for landing (42.33 KB, patch)
2013-03-21 09:23 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-03-14 16:33:53 PDT
Created attachment 193199 [details] Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated.
Tony Chang
Comment 2 2013-03-20 15:10:49 PDT
Comment on attachment 193199 [details] Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated. LGTM. Please add some tests with bothRowBothColumn.
Julien Chaffraix
Comment 3 2013-03-21 09:23:32 PDT
Created attachment 194278 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-03-21 10:17:20 PDT
Comment on attachment 194278 [details] Patch for landing Clearing flags on attachment: 194278 Committed r146482: <http://trac.webkit.org/changeset/146482>
WebKit Review Bot
Comment 5 2013-03-21 10:17:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.