| Summary: | [EFL][WK2] Use C API inside ewk_cookie_manager | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, ap, benjamin, gyuyoung.kim, kenneth, lucas.de.marchi, mikhail.pozdnyakov, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 107657, 107666 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2013-01-23 04:08:40 PST
Created attachment 184208 [details]
Patch
Attachment 184208 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.cpp', u'Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.h', u'Source/WebKit2/UIProcess/API/efl/ewk_context.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h']" exit_code: 1
Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.h:36: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.h:37: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 184208 [details] Patch Clearing flags on attachment: 184208 Committed r140542: <http://trac.webkit.org/changeset/140542> All reviewed patches have been landed. Closing bug. |