| Summary: | Build Apple Windows 7 port in VS2010 in 32 and 64 bit | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||||
| Component: | Tools / Tests | Assignee: | Roger Fong <roger_fong> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ashodnakashian, bfulgham, divakar.webkit, jonlee, ossy, roger_fong, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Bug Depends on: | 106986, 106987, 106988, 106989, 107034, 107037 | ||||||||||||
| Bug Blocks: | 107038, 107714 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Roger Fong
2013-01-15 15:33:24 PST
Thanks for working on this. Let me know if I can help with anything. The plan for this is to start with 32 bit and get everything working until other parties like CoreFoundation get their libraries converted to 64 bit. At that point we'll flip the switch and see what problems arise. So far the VS2010'ing process is going fairly smoothly. But I expect I may run into unexpected problems when flipping the 64 bit switch and may need some help there :). I'll be filing subtask bugs for each different parts of the webkit solution that need to converted. The hope is to check each part as separate chunks. I'm placing each section in a folder called $(ProjectName)2010.vcproj which lives along side the original vs2005 $(ProjectName).vcproj folder. Ideally the hope is that when the whole solution is converted we can nuke the vs2005 solution in favor of the new one. Side Note: I've only been setting up Debug and Release configurations as I haven't seen really any differences between production/release and debug/debug_all. Maybe someone else can enlighten me on this one though. It looks like we only ever build Debug or Release on the Apple Windows port anyways? Created attachment 183636 [details]
WebKitLibraries Property Sheets
WebKit Libraries property sheets.
I funneled a number of common settings to these property sheets since they were being unnecessarily repeated in property sheets higher up in the property hierarchy.
Created attachment 183637 [details]
WebKit Solution file
By the way, I changed some environment variable names. WEBKITLIBRARIES -> WEBKIT_LIBRARIES WEBKITOUTPUTDIR -> WEBKIT_OUTPUTDIR WEBKIT_TESTFONTS (stayed the same) Added WEBKIT_SOURCE to point to Source directory of webkit checkout I added this to get rid of some ridiculous relative paths in the build scripts (../../../../../../ etc etc). Comment on attachment 183637 [details]
WebKit Solution file
Not sure why I kept the name of this project as WebKit2010.
Renaming it and updating solution to use projects in the updated folder names for each project (for example, WTF.vcxproj instead of WTF2010.vcproj)
Created attachment 184093 [details]
WebKit Solution file
Review on these too please? Comment on attachment 183636 [details]
WebKitLibraries Property Sheets
Looks great. r=me.
Comment on attachment 184093 [details] WebKit Solution file View in context: https://bugs.webkit.org/attachment.cgi?id=184093&action=review Looks good. I think the ChangeLog comments are out-of-sync with the actual directory name you used. Please correct when landing. r=me. > ChangeLog:9 > + * WebKit2010.vcproj: Added. WebKit2010.vcxproj added? :-) > ChangeLog:10 > + * WebKit2010.vcproj/WebKit2010.sln: Added. Ditto. > WebKit.vcxproj/WebKit2010.sln:1 > + I don't think you need to 2010 on the solution file. It's in its own WebKit.vcxproj directory, so will not conflict with the VS2005 version. Oops, coulda sworn I changed that solution name. Anyways fixed that and the Changelog, committed WebKitLibraries property sheets: r140567 WebKit Solution file: r140568 Rechecked in solution file: http://trac.webkit.org/changeset/140597 Previous checkin has references to projects that don't exist in an OpenSource build. (In reply to comment #14) > Rechecked in solution file: http://trac.webkit.org/changeset/140597 > > Previous checkin has references to projects that don't exist in an OpenSource build. It broke all EWS bots, could you fix it, please? See https://bugs.webkit.org/show_bug.cgi?id=96934#c6 for details. Sorry, just committed the fix. Were the EWS bots fine before this? I've been checking in a ton of vcxproj files so I'm surprised it hasn't complained about those yet. (In reply to comment #16) > Sorry, just committed the fix. > Were the EWS bots fine before this? I've been checking in a ton of vcxproj files so I'm surprised it hasn't complained about those yet. Yep, they were happy and are/will happy after http://trac.webkit.org/changeset/140603. :) Thanks for the quick fix. Created attachment 186203 [details]
Modifications to WebKitLibraries
Changes to common.props and adds a temporary auto-version script for use only by the VS2010 solution.
Will be removed when we nuke the 2005 solution.
But we need support for Visual Studio 2005 as well! (In reply to comment #19) > But we need support for Visual Studio 2005 as well! Why? *** Bug 77517 has been marked as a duplicate of this bug. *** Comment on attachment 186203 [details]
Modifications to WebKitLibraries
Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
|