Bug 106988 - Get WebCore compiling in VS2010 (32 bit)
Summary: Get WebCore compiling in VS2010 (32 bit)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Roger Fong
URL:
Keywords: InRadar
Depends on: 106987
Blocks: 106949 106989
  Show dependency tree / graph
 
Reported: 2013-01-16 01:18 PST by Roger Fong
Modified: 2013-01-28 15:20 PST (History)
4 users (show)

See Also:

Attachments
WebCore property sheets, project files and modified buildscripts (1.31 MB, patch)
2013-01-19 15:47 PST, Roger Fong 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Updated WebCore property sheets and WebCore solution file (9.74 KB, patch)
2013-01-24 17:41 PST, Roger Fong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-01-16 01:18:06 PST 
This includes WebCore, WebCoreGenerated and QTMovieWin.
Comment 1 Radar WebKit Bug Importer 2013-01-16 01:18:43 PST 
<rdar://problem/13022798>
Comment 2 Roger Fong 2013-01-17 18:46:40 PST 
Done, will start uploading changes thus far.
Comment 3 Roger Fong 2013-01-19 15:47:19 PST 
Created attachment 183642 [details]
WebCore property sheets, project files and modified buildscripts

Also removed a forwarding headers directory that was empty/not being used anymore.
Comment 4 Roger Fong 2013-01-23 11:34:05 PST 
Could I can an r? Thanks
Comment 5 Brent Fulgham 2013-01-23 12:03:04 PST 
Comment on attachment 183642 [details]
WebCore property sheets, project files and modified buildscripts

View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review

rs=me.  I do think it would be better to use "WebCore.vcxproj" as the directory name.

> ChangeLog:8
> +        * ForwardingHeaders/wtf: Removed.

Did you actually remove ForwardingHeaders subdirectories? Why?  The patch doesn't seem to do anything to these guys.

> ChangeLog:15
> +        * WebCore.vcproj/WebCore.sln:

How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version?

> ChangeLog:16
> +        * WebCore2010.vcproj: Added.

How about WebCore.vcxproj instead of WebCore2010?
Comment 6 Roger Fong 2013-01-23 12:06:56 PST 
(In reply to comment #5)
> (From update of attachment 183642 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review
> 
> rs=me.  I do think it would be better to use "WebCore.vcxproj" as the directory name.
> 
> > ChangeLog:8
> > +        * ForwardingHeaders/wtf: Removed.
> 
> Did you actually remove ForwardingHeaders subdirectories? Why?  The patch doesn't seem to do anything to these guys.

mm yeah, i should probably stick that in a separate patch. It's just an unused subdirectory. I'll remove that from the patch.

> 
> > ChangeLog:15
> > +        * WebCore.vcproj/WebCore.sln:
> 
> How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version?

I think that's an accidental change. I don't think I even made a VS2010 WebCore solution itself. Do we need a solution specifically for WebCore?


> > ChangeLog:16
> > +        * WebCore2010.vcproj: Added.
> 
> How about WebCore.vcxproj instead of WebCore2010?

Oops, changed that, guess that's an old patch.
Comment 7 Roger Fong 2013-01-24 17:41:58 PST 
Created attachment 184620 [details]
Updated WebCore property sheets and WebCore solution file