Bug 106988 – Get WebCore compiling in VS2010 (32 bit)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Roger Fong]

This includes WebCore, WebCoreGenerated and QTMovieWin.

[Radar WebKit Bug Importer]

<rdar://problem/13022798>

[Roger Fong]

Done, will start uploading changes thus far.

[Roger Fong]

Created attachment 183642 [details]
WebCore property sheets, project files and modified buildscripts

Also removed a forwarding headers directory that was empty/not being used anymore.

[Roger Fong]

Could I can an r? Thanks

[Brent Fulgham]

Comment on attachment 183642 [details]
WebCore property sheets, project files and modified buildscripts

View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review

rs=me.  I do think it would be better to use "WebCore.vcxproj" as the directory name.

> ChangeLog:8
> +        * ForwardingHeaders/wtf: Removed.

Did you actually remove ForwardingHeaders subdirectories? Why?  The patch doesn't seem to do anything to these guys.

> ChangeLog:15
> +        * WebCore.vcproj/WebCore.sln:

How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version?

> ChangeLog:16
> +        * WebCore2010.vcproj: Added.

How about WebCore.vcxproj instead of WebCore2010?

[Roger Fong]

(In reply to comment #5)
> (From update of attachment 183642 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183642&action=review
> 
> rs=me.  I do think it would be better to use "WebCore.vcxproj" as the directory name.
> 
> > ChangeLog:8
> > +        * ForwardingHeaders/wtf: Removed.
> 
> Did you actually remove ForwardingHeaders subdirectories? Why?  The patch doesn't seem to do anything to these guys.

mm yeah, i should probably stick that in a separate patch. It's just an unused subdirectory. I'll remove that from the patch.

> 
> > ChangeLog:15
> > +        * WebCore.vcproj/WebCore.sln:
> 
> How about putting this solution file in WebCore.vcxproj, so that it does not clobber the VS2005 version?

I think that's an accidental change. I don't think I even made a VS2010 WebCore solution itself. Do we need a solution specifically for WebCore?


> > ChangeLog:16
> > +        * WebCore2010.vcproj: Added.
> 
> How about WebCore.vcxproj instead of WebCore2010?

Oops, changed that, guess that's an old patch.

[Roger Fong]

Created attachment 184620 [details]
Updated WebCore property sheets and WebCore solution file