Bug 106987 – Get JavascriptCore compiling in VS2010 (32bit)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Roger Fong]

This includes LLIntDesiredOffsets,LLIntOffsetsExtractor, LLIntAssembly, JavaScriptCoreGenerated, JavaScriptCore and jsc projects.

[Radar WebKit Bug Importer]

<rdar://problem/13022729>

[Roger Fong]

jsc for some reason crashes when being run in debug mode (but not release).
Otherwise, this part is also done.

[Roger Fong]

Created attachment 183640 [details]
JavaScript project files, buildscripts and property sheets

[Brent Fulgham]

Comment on attachment 183640 [details]
JavaScript project files, buildscripts and property sheets

View in context: https://bugs.webkit.org/attachment.cgi?id=183640&action=review

Do we really need to have a JavaScriptCore2010.vcproj directory?  VS 2010 uses "vxcproj" as the extension, so you could call is "JavaScriptCore.vcxproj" without conflict.

Also, this change removes the WinCairo support stuff.  This is no big deal, I can file a separate bug to add the property sheets I need.

I think this looks good as-is, but I'll hold off approving until you confirm my question about the assembly listing file.

> JavaScriptCore2010.vcproj/JavaScriptCore.resources/Info.plist:10
> +	<string>530, Copyright 2003-2010 Apple Inc.</string>

Copyright 2013?

> JavaScriptCore2010.vcproj/JavaScriptCoreExports.def:2
> +

Can we switch to using the export definition generator I built for WebKit/WebCore a few weeks ago?  This would be nice because:
1. We could maintain VS2005 compatibility if anyone needs that
2. We could support VS2012 and beyond without breaking old symbol files.
3. We can optionally add/remove symbol exports using CPP macro conditionals.

> JavaScriptCore2010.vcproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.asm:1
> +; Listing generated by Microsoft (R) Optimizing Compiler Version 16.00.40219.01 

Isn't this generated as part of the build? Was this intended to be checked in?

[Roger Fong]

> Do we really need to have a JavaScriptCore2010.vcproj directory?  VS 2010 uses "vxcproj" as the extension, so you could call is "JavaScriptCore.vcxproj" without conflict.

Hmm, yeah ok, I'll do that

> Also, this change removes the WinCairo support stuff.  This is no big deal, I can file a separate bug to add the property sheets I need.

Yeah, sry bout that, I don't think I'm going to be touching the Cairo files.
Would rather not touch something I don't use/know nothing about.

> Copyright 2013?

Looks like that hasn't been updated in a while huh...I'll go change that.

> > JavaScriptCore2010.vcproj/JavaScriptCoreExports.def:2
> > +
> 
> Can we switch to using the export definition generator I built for WebKit/WebCore a few weeks ago?  This would be nice because:
> 1. We could maintain VS2005 compatibility if anyone needs that
> 2. We could support VS2012 and beyond without breaking old symbol files.
> 3. We can optionally add/remove symbol exports using CPP macro conditionals.

Do you mean just adding another project that mirrors the WebKitExportGenerator project? (except in JSC of course) Or perhaps move the WebKitExportGenerator project into a generic ExportGenerator project that compiles before both JavascriptCore and WebKitLib.

JavaScriptCore2010.vcproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.asm:1
> Isn't this generated as part of the build? Was this intended to be checked in?

Oops no, that shouldn't be there.

[Brent Fulgham]

(In reply to comment #5)
> > > JavaScriptCore2010.vcproj/JavaScriptCoreExports.def:2
> > > +
> > 
> > Can we switch to using the export definition generator I built for WebKit/WebCore a few weeks ago?  This would be nice because:

> Do you mean just adding another project that mirrors the WebKitExportGenerator project? (except in JSC of course) Or perhaps move the WebKitExportGenerator project into a generic ExportGenerator project that compiles before both JavascriptCore and WebKitLib.

The project may not have been necessary; we might be able to build the thing using another stanza in the existing JavaScriptCoreGenerated and WebCoreGenerated makefiles.  That would probably be better (having more projects generally slows down VS).

Why don't you land what you have, and we (I?) can submit a separate patch to autogenerate things.

[Roger Fong]

http://trac.webkit.org/changeset/140472

Okay cool, yeah adding it to the *generated projects sounds great.
I was about to get to the WebKitExportGenerator project in my build steps, but I'll just check in my WebCore project files and then you can add the exports generator to both of the "generated" projects together.

That sound okay?
Also can you slap an r+ on this bug and briefly look over my WebCore patch so I don't have to feel guilty about checking in without actually getting the r+? :)

[Brent Fulgham]

Comment on attachment 183640 [details]
JavaScript project files, buildscripts and property sheets

Looks good, but please consider the items I mentioned when you land it.

Visual studio projects are fun!

[Brent Fulgham]

(In reply to comment #7)
> http://trac.webkit.org/changeset/140472
> 
> Okay cool, yeah adding it to the *generated projects sounds great.
> I was about to get to the WebKitExportGenerator project in my build steps, but I'll just check in my WebCore project files and then you can add the exports generator to both of the "generated" projects together.
> 
> That sound okay?

Perfect!

> Also can you slap an r+ on this bug and briefly look over my WebCore patch so I don't have to feel guilty about checking in without actually getting the r+? :)

Done.

[Roger Fong]

(In reply to comment #8)
> (From update of attachment 183640 [details])
> Looks good, but please consider the items I mentioned when you land it.

Yup, I made those changes locally, just didn't upload the patch.

> Visual studio projects are fun!

Conversion wizard is less fun :(, tried to use it for just WebCore, made a bunch of headers into sources. wha?

[Brent Fulgham]

It doesn't look like the JavaScriptCore solution made it into the landing.

Could you please land your "JavaScriptCore.vcxproj/JavaScriptCore.sln" file so I could try it out?

[Roger Fong]

Created attachment 184584 [details]
JavaScriptCore solution and testAPI/testRegExp projects

Made some more changes to JSC VS2010, including adding a solution for just JSC, adding some test projects, and cleaning up property sheets. Namely, the ConfigSuffixes are not needed since we build different configurations into different locations anyways.

[Roger Fong]

Note that the test projects I added don't run properly yet. I'm not sure that they do in the VS2005 build either, I'll check after I fix the current build.

[Brent Fulgham]

Comment on attachment 183640 [details]
JavaScript project files, buildscripts and property sheets

Marking obsolete, as this portion has already been landed.

[Brent Fulgham]

Comment on attachment 184584 [details]
JavaScriptCore solution and testAPI/testRegExp projects

Looks good.

[Brent Fulgham]

Can you please land the patch locally?  I can't seem to apply the current patch on my local tree due to conflict with the JavaScriptCore.vcxproj and so forth.  Maybe the patch is out of date against the current tree.

[Roger Fong]

Good to go here.