Bug 107037 - Get WinLauncher to compile in VS2010 (32 bit)
Summary: Get WinLauncher to compile in VS2010 (32 bit)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Roger Fong
URL:
Keywords: InRadar
Depends on: 106989
Blocks: 106949
  Show dependency tree / graph
 
Reported: 2013-01-16 11:08 PST by Roger Fong
Modified: 2013-02-06 17:55 PST (History)
4 users (show)

See Also:

Attachments
WinLauncher patch (20.00 KB, patch)
2013-02-06 13:54 PST, Roger Fong 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-01-16 11:08:50 PST 
This includes WinLauncher, and WinLauncherLauncher
Comment 1 Radar WebKit Bug Importer 2013-01-16 11:09:27 PST 
<rdar://problem/13025771>
Comment 2 Roger Fong 2013-02-06 13:54:18 PST 
Created attachment 186915 [details]
WinLauncher patch

Property sheets, projects, resources
Comment 3 Brent Fulgham 2013-02-06 15:44:37 PST 
Comment on attachment 186915 [details]
WinLauncher patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186915&action=review

Looks good.  Do you think we could change the project names as I mentioned?

> WinLauncher/WinLauncher.vcxproj/WinLauncherLauncher.vcxproj:15
> +    <RootNamespace>WinLauncherLauncher</RootNamespace>

One thing I hate about this is that the executable is "WinLauncher.exe", but the project is "WinLauncherLauncher", so you can't set this as a target and debug directly. I wonder if "WinLauncher" could become "WinLauncherLib", and "WinLauncherLauncher" could just be "WinLauncher"?
Comment 4 Roger Fong 2013-02-06 17:55:07 PST 
Committed: http://trac.webkit.org/changeset/142059

Will add projects to the opensource solution in another patch along with some other various solution wide touchups.