| Summary: | Disassembly methods should be able to disassemble to any PrintStream& rather than always using WTF::dataFile() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 103009 | ||||||||
| Bug Blocks: | 102999 | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2012-11-28 00:59:25 PST
Created attachment 176421 [details] work in progress This needs to wait for https://bugs.webkit.org/show_bug.cgi?id=103009 Created attachment 176589 [details]
the patch
Comment on attachment 176589 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=176589&action=review r=me with the one comment change. > Source/JavaScriptCore/dfg/DFGGraph.cpp:219 > + out.print(", "); // If this is the third child is the first non-empty one then make sure we have two blanks preceding it. "If the third child is the first non-empty one then make sure we have two blanks preceding it." ? Landed in http://trac.webkit.org/changeset/136069 |