Bug 103492

Summary: Disassembly methods should be able to disassemble to any PrintStream& rather than always using WTF::dataFile()
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 103009    
Bug Blocks: 102999    
Attachments:
Description Flags
work in progress
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2012-11-28 00:59:25 PST
Patch forthcoming.
Attachments
work in progress (30.79 KB, patch)
2012-11-28 01:06 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (30.84 KB, patch)
2012-11-28 15:30 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-28 01:06:11 PST
Created attachment 176421 [details] work in progress This needs to wait for https://bugs.webkit.org/show_bug.cgi?id=103009
Filip Pizlo
Comment 2 2012-11-28 15:30:10 PST
Created attachment 176589 [details] the patch
Mark Hahnenberg
Comment 3 2012-11-28 15:34:52 PST
Comment on attachment 176589 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=176589&action=review r=me with the one comment change. > Source/JavaScriptCore/dfg/DFGGraph.cpp:219 > + out.print(", "); // If this is the third child is the first non-empty one then make sure we have two blanks preceding it. "If the third child is the first non-empty one then make sure we have two blanks preceding it." ?
Filip Pizlo
Comment 4 2012-11-30 17:24:46 PST
Landed in http://trac.webkit.org/changeset/136069
Note You need to log in before you can comment on or make changes to this bug.