Bug 103000

Summary:

Any function that can log things should be able to easily log them to a memory buffer as well

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, dglazkov, ggaren, gyuyoung.kim, laszlo.gombos, mark.lam, mhahnenberg, ojan, oliver, rakuco, sam, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

102999, 103009

Attachments:

Description	Flags
work in progress	none
the patch	webkit-ews: commit-queue-
the patch	none
the patch	buildbot: commit-queue-
the patch	webkit.review.bot: commit-queue-
the patch	sam: review+

Filip Pizlo

Reported 2012-11-21 18:16:27 PST

So anytime that we can do: thing->dump(); We should be able to *also* optionally do something like: StringStream stream; thing->dump(stream); String string = stream.string();

Attachments
work in progress (43.56 KB, patch) 2012-11-21 20:12 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (43.12 KB, patch) 2012-11-21 20:47 PST, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
the patch (44.45 KB, patch) 2012-11-21 21:06 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (44.46 KB, patch) 2012-11-21 21:15 PST, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
the patch (44.51 KB, patch) 2012-11-22 00:09 PST, Filip Pizlo	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
the patch (37.58 KB, patch) 2012-11-22 20:18 PST, Filip Pizlo	sam: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-11-21 20:12:53 PST

Created attachment 175573 [details] work in progress

Filip Pizlo

Comment 2 2012-11-21 20:47:05 PST

Created attachment 175577 [details] the patch

WebKit Review Bot

Comment 3 2012-11-21 20:49:15 PST

Attachment 175577 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/DataLog.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/PrintStream.h:85: Omit int when using unsigned [runtime/unsigned] [1] Source/WTF/wtf/PrintStream.cpp:101: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 4 2012-11-21 20:55:58 PST

Comment on attachment 175577 [details] the patch Attachment 175577 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14969200

Early Warning System Bot

Comment 5 2012-11-21 20:58:56 PST

Comment on attachment 175577 [details] the patch Attachment 175577 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14962232

Filip Pizlo

Comment 6 2012-11-21 21:06:31 PST

Created attachment 175581 [details] the patch Rabased and fixed some #include bugs.

WebKit Review Bot

Comment 7 2012-11-21 21:09:21 PST

Attachment 175581 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/DataLog.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/PrintStream.h:85: Omit int when using unsigned [runtime/unsigned] [1] Source/WTF/wtf/PrintStream.cpp:101: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 8 2012-11-21 21:15:14 PST

Created attachment 175582 [details] the patch Fix style.

Build Bot

Comment 9 2012-11-21 23:03:56 PST

Comment on attachment 175582 [details] the patch Attachment 175582 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14966224

EFL EWS Bot

Comment 10 2012-11-21 23:36:12 PST

Comment on attachment 175582 [details] the patch Attachment 175582 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14969237

Filip Pizlo

Comment 11 2012-11-22 00:09:26 PST

Created attachment 175603 [details] the patch More build fixes.

WebKit Review Bot

Comment 12 2012-11-22 07:10:33 PST

Comment on attachment 175603 [details] the patch Attachment 175603 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14967379 New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

Filip Pizlo

Comment 13 2012-11-22 20:18:47 PST

Created attachment 175728 [details] the patch

Filip Pizlo

Comment 14 2012-11-23 19:17:52 PST

Landed in http://trac.webkit.org/changeset/135640

Note You need to log in before you can comment on or make changes to this bug.