Bug 102089

Summary: Update DOMException name: DOMStringSizeError
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101606    
Attachments:
Description Flags
Patch
none
Patch for landing none

Erik Arvidsson
Reported 2012-11-13 08:09:45 PST
Update DOMException name: DOMStringSizeError
Attachments
Patch (2.29 KB, patch)
2012-11-13 08:11 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.38 KB, patch)
2012-11-15 11:36 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-11-13 08:11:04 PST
Created attachment 173896 [details] Patch
Ojan Vafai
Comment 2 2012-11-13 08:51:42 PST
Comment on attachment 173896 [details] Patch Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions?
Erik Arvidsson
Comment 3 2012-11-13 08:59:51 PST
(In reply to comment #2) > (From update of attachment 173896 [details]) > Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions? Yes, lets do that https://bugs.webkit.org/show_bug.cgi?id=102095
Erik Arvidsson
Comment 4 2012-11-15 07:55:07 PST
Ojan, can I get an r+ on this one?
WebKit Review Bot
Comment 5 2012-11-15 10:14:37 PST
Comment on attachment 173896 [details] Patch Rejecting attachment 173896 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: le Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/DOMCoreException.cpp Hunk #1 FAILED at 36. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej patching file Source/WebCore/dom/ExceptionCode.h Hunk #1 succeeded at 35 with fuzz 1 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14848442
Erik Arvidsson
Comment 6 2012-11-15 11:36:58 PST
Created attachment 174492 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-11-15 15:26:50 PST
Comment on attachment 174492 [details] Patch for landing Clearing flags on attachment: 174492 Committed r134840: <http://trac.webkit.org/changeset/134840>
WebKit Review Bot
Comment 8 2012-11-15 15:26:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.