Bug 101604 – Replace DOMException TYPE_MISMATCH_ERR with TypeError

• Component: DOM
• Status: RESOLVED CONFIGURATION CHANGED

[Erik Arvidsson]

Tracking Bug

We are using TYPE_MISMATCH_ERR in cases where we shouldn't and it is likely that this will be deprecated too:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=19898

[Erik Arvidsson]

Created attachment 173341 [details]
Patch

[Adam Barth]

Comment on attachment 173341 [details]
Patch

ok

[Erik Arvidsson]

Created attachment 173653 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 173653 [details]
Patch for landing

Rejecting attachment 173653 [details] from commit-queue.

New failing tests:
media/encrypted-media/encrypted-media-syntax.html
fast/mediastream/RTCPeerConnection.html
Full output: http://queues.webkit.org/results/14821221

[Erik Arvidsson]

Created attachment 173737 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 173737 [details]
Patch for landing

Clearing flags on attachment: 173737

Committed r134345: <http://trac.webkit.org/changeset/134345>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Raphael Kubo da Costa (:rakuco)]

Qt updated its text expectation for fast/dynamic/insertAdjacentElement.html in r134388 and I've updated the expectations for GTK+, Mac and EFL in r134426.

CC'ing Roger since I don't have a Mac to fix the pixel expectations for it.

[Darin Adler]

Comment on attachment 173737 [details]
Patch for landing

This caused me to look at bug 91679, where NATIVE_TYPE_ERR was added.

Unfortunately, that patch did not correctly add this new error code for bindings other than JavaScript, so using this new error code in lots of new places makes a potential problem with NATIVE_TYPE_ERR now a practical problem, for the Objective-C bindings for example. This needs to be fixed. Please see my comments in bug 91679 for details.

I suggest rolling this change back until those issues are dealt with, or dealing with them quickly.

[WebKit Review Bot]

Re-opened since this is blocked by bug 102106

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #8)
> Qt updated its text expectation for fast/dynamic/insertAdjacentElement.html in r134388 and I've updated the expectations for GTK+, Mac and EFL in r134426.
> 
> CC'ing Roger since I don't have a Mac to fix the pixel expectations for it.

... Qt, GTK+, Mac and EFL expectations fixed in <http://trac.webkit.org/changeset/134444> after the rollout.

[Joshua Bell]

(In reply to comment #11)
> (In reply to comment #8)
> > Qt updated its text expectation for fast/dynamic/insertAdjacentElement.html in r134388 and I've updated the expectations for GTK+, Mac and EFL in r134426.
> > 
> > CC'ing Roger since I don't have a Mac to fix the pixel expectations for it.
> 
> ... Qt, GTK+, Mac and EFL expectations fixed in <http://trac.webkit.org/changeset/134444> after the rollout.

I should have rolled those other patches out at the same time. :( Sorry, and thanks for cleaning up.

[Ahmad Saleem]

It seems that it landed - https://github.com/WebKit/WebKit/commit/3b3c21cf5baed280eeb9d4762f6a761f29e41aaf

--> [e-mail] - Is something needed here? Thanks!

[Ryosuke Niwa]

(In reply to Ahmad Saleem from comment #13)
> It seems that it landed -
> https://github.com/WebKit/WebKit/commit/
> 3b3c21cf5baed280eeb9d4762f6a761f29e41aaf
> 
> --> [e-mail] - Is something needed here? Thanks!

The patch got rolled out but we do use TypeError for these nowadays.

[Radar WebKit Bug Importer]

<rdar://problem/98618720>