Bug 99982 - [EFL][WK2] Make the resource load client a C++ class
Summary: [EFL][WK2] Make the resource load client a C++ class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 99992
  Show dependency tree / graph
 
Reported: 2012-10-22 05:22 PDT by Chris Dumez
Modified: 2012-10-22 12:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (30.17 KB, patch)
2012-10-22 07:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (30.38 KB, patch)
2012-10-22 09:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-22 05:22:18 PDT 
The Resource load client is currently tightly integrated to the view and uses C style.

We should move all the resource load client code to its own C++ class.
Comment 1 Chris Dumez 2012-10-22 07:08:57 PDT 
Created attachment 169904 [details]
Patch
Comment 2 Chris Dumez 2012-10-22 09:03:23 PDT 
Comment on attachment 169904 [details]
Patch

Will move the class to WebKit namespace.
Comment 3 Chris Dumez 2012-10-22 09:50:50 PDT 
Created attachment 169929 [details]
Patch

Move client to WebKit namespace.
Comment 4 Kenneth Rohde Christiansen 2012-10-22 12:37:02 PDT 
Comment on attachment 169929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169929&action=review

r=me

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:839
> +    priv->resourceLoadClient = ResourceLoadClientEfl::create(ewkView);

why not call it ResourceLoaderClientEfl to show the relation to FrameLoaderClient

> Source/WebKit2/UIProcess/efl/ResourceLoadClientEfl.cpp:131
> +    WKPageResourceLoadClient wkResourceLoadClient;

Ah I see now...
Comment 5 WebKit Review Bot 2012-10-22 12:53:18 PDT 
Comment on attachment 169929 [details]
Patch

Clearing flags on attachment: 169929

Committed r132122: <http://trac.webkit.org/changeset/132122>
Comment 6 WebKit Review Bot 2012-10-22 12:53:22 PDT 
All reviewed patches have been landed.  Closing bug.