Bug 99947 – Handle two-finger tap gestures in the same way as long-press gestures

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Terry Anderson]

Currently a long-press gesture is used to dispatch a context menu (for platforms defining CONTEXT_MENUS) or to select text (for Android). Additionally, for platforms defining TOUCH_ADJUSTMENT, gesture target fuzzing is performed on the location and touch area of the long-press gesture.

This CL will cause two-finger tap gestures to be handled in the same way as long-press gestures. The location and touch area of a two-finger tap gesture will correspond to the location and touch area of the first finger down; the location/area of the second finger will be ignored.

[Terry Anderson]

Created attachment 169821 [details]
Patch

[Terry Anderson]

Comment on attachment 169821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169821&action=review

> Source/WebCore/page/EventHandler.cpp:2526
>          return handleGestureLongPress(gestureEvent);

Is this OK or should I instead have a handleGestureLongPress() and a handleGestureTwoFingerTap() which both call a common function containing the current implementation of handleGestureLongPress() ?

[Adam Barth]

Comment on attachment 169821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169821&action=review

>> Source/WebCore/page/EventHandler.cpp:2526
>>          return handleGestureLongPress(gestureEvent);
> 
> Is this OK or should I instead have a handleGestureLongPress() and a handleGestureTwoFingerTap() which both call a common function containing the current implementation of handleGestureLongPress() ?

Its probably clearer to do that.  This code really just wants to dispatch based on the type without making any policy decisions about what the gestures mean.

[Terry Anderson]

Created attachment 170256 [details]
Patch for landing

[Allan Sandfeld Jensen]

I still believe both of these gestures should be named GestureContextMenu, since there can be different ways to trigger that, and two finger taps might be used for other purposes on other platforms.

[Terry Anderson]

Created attachment 170430 [details]
Patch for landing after fixing merge conflicts with WK99520

[Terry Anderson]

(In reply to comment #5)
> I still believe both of these gestures should be named GestureContextMenu, since there can be different ways to trigger that, and two finger taps might be used for other purposes on other platforms.

I have created https://bugs.webkit.org/show_bug.cgi?id=100270 to discuss this suggestion. Let's land this patch as-is for the time being.

[Allan Sandfeld Jensen]

(In reply to comment #7)
> (In reply to comment #5)
> > I still believe both of these gestures should be named GestureContextMenu, since there can be different ways to trigger that, and two finger taps might be used for other purposes on other platforms.
> 
> I have created https://bugs.webkit.org/show_bug.cgi?id=100270 to discuss this suggestion. Let's land this patch as-is for the time being.

Fine by me. The patch looks good to me too.

[WebKit Review Bot]

Comment on attachment 170430 [details]
Patch for landing after fixing merge conflicts with WK99520

Clearing flags on attachment: 170430

Committed r132406: <http://trac.webkit.org/changeset/132406>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.