Bug 99763 – [chromium] Storing the enclosing rect dimensions of the first finger for a two finger tap

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Terry Anderson]

Add a struct |twoFingerTap| inside the union |data| of a WebGestureEvent. The fields |firstFingerWidth| and |firstFingerHeight| will represent the dimensions of the enclosing rectangle corresponding to the first touch point in the gesture. These will be used in a future CL to perform target fuzzing on a two-finger tap gesture.

Note: I chose not to name the two fields |width| and |height| so that they aren't confused with the width and height of the gesture's bounding box, which contains the enclosing rectangles of both touch points. My future fuzzing CL will only be concerned with the location and enclosing rectangle of the first touch point.

[Terry Anderson]

Created attachment 169488 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 169488 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/public/WebInputEvent.h:401:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/public/WebInputEvent.h:403:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 169488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169488&action=review

>> Source/WebKit/chromium/public/WebInputEvent.h:401
>> +      } twoFingerTap;
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Would you be willing to fix the style in this file?  I realize that you're just mimicing an existing error, but we should fix it.

[Terry Anderson]

Created attachment 169814 [details]
Indent style fixed

[WebKit Review Bot]

Comment on attachment 169814 [details]
Indent style fixed

Clearing flags on attachment: 169814

Committed r132021: <http://trac.webkit.org/changeset/132021>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.