Bug 99902 – [WK2][EFL] Modify ewk_view_scale_set to public API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KyungTae Kim]

The function ewk_view_scale_set need to be public API for a scale setting on external programs.

[KyungTae Kim]

Created attachment 169749 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 169749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review

I think it would be good if you add test case as well.

> Source/WebKit2/ChangeLog:3
> +        [WK2][EFL] Modify ewk_view_scale_set  to public API

set to -> set to. Remove unneeded a space.

[KyungTae Kim]

Created attachment 169752 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 169749 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review
> 
> I think it would be good if you add test case as well.

I set r- because this patch should be added with test case.

[KyungTae Kim]

If the 'test case' means a unit test test case, it is on the other bug:
https://bugs.webkit.org/show_bug.cgi?id=99451

This is for fixing error on the build bot for that and 99285.

I uploaded without test case because a similar case was merged without test case before : ​https://bugs.webkit.org/show_bug.cgi?id=94589

[WebKit Review Bot]

Comment on attachment 169752 [details]
Patch

Clearing flags on attachment: 169752

Committed r131976: <http://trac.webkit.org/changeset/131976>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.