Bug 99902 - [WK2][EFL] Modify ewk_view_scale_set to public API
Summary: [WK2][EFL] Modify ewk_view_scale_set to public API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks: 99451
  Show dependency tree / graph
 
Reported: 2012-10-19 19:59 PDT by KyungTae Kim
Modified: 2012-10-19 21:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2012-10-19 20:01 PDT, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2012-10-19 21:28 PDT, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2012-10-19 19:59:11 PDT 
The function ewk_view_scale_set need to be public API for a scale setting on external programs.
Comment 1 KyungTae Kim 2012-10-19 20:01:55 PDT 
Created attachment 169749 [details]
Patch
Comment 2 Gyuyoung Kim 2012-10-19 21:18:31 PDT 
Comment on attachment 169749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review

I think it would be good if you add test case as well.

> Source/WebKit2/ChangeLog:3
> +        [WK2][EFL] Modify ewk_view_scale_set  to public API

set to -> set to. Remove unneeded a space.
Comment 3 KyungTae Kim 2012-10-19 21:28:47 PDT 
Created attachment 169752 [details]
Patch
Comment 4 Gyuyoung Kim 2012-10-19 21:31:46 PDT 
(In reply to comment #2)
> (From update of attachment 169749 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review
> 
> I think it would be good if you add test case as well.

I set r- because this patch should be added with test case.
Comment 5 KyungTae Kim 2012-10-19 21:33:50 PDT 
If the 'test case' means a unit test test case, it is on the other bug:
https://bugs.webkit.org/show_bug.cgi?id=99451

This is for fixing error on the build bot for that and 99285.

I uploaded without test case because a similar case was merged without test case before : ​https://bugs.webkit.org/show_bug.cgi?id=94589
Comment 6 WebKit Review Bot 2012-10-19 21:52:41 PDT 
Comment on attachment 169752 [details]
Patch

Clearing flags on attachment: 169752

Committed r131976: <http://trac.webkit.org/changeset/131976>
Comment 7 WebKit Review Bot 2012-10-19 21:52:45 PDT 
All reviewed patches have been landed.  Closing bug.