Bug 99451 - [EFL][WK2] Add API unit tests for scaling
Summary: [EFL][WK2] Add API unit tests for scaling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on: 99902
Blocks: 90451
  Show dependency tree / graph
 
Reported: 2012-10-16 04:16 PDT by Jinwoo Song
Modified: 2012-10-19 22:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2012-10-18 09:09 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2012-10-19 08:23 PDT, Jinwoo Song 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
rebased patch (2.00 KB, patch)
2012-10-19 21:47 PDT, Jinwoo Song 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
rebased patch (2.00 KB, patch)
2012-10-19 22:15 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-10-16 04:16:22 PDT 
API unit tests for ewk_view_scale_set/get() should be added.
Comment 1 Jinwoo Song 2012-10-18 09:09:10 PDT 
Created attachment 169424 [details]
Patch
Comment 2 Gyuyoung Kim 2012-10-18 09:18:55 PDT 
Comment on attachment 169424 [details]
Patch

Attachment 169424 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14456097
Comment 3 Jinwoo Song 2012-10-19 08:23:53 PDT 
Created attachment 169622 [details]
Patch
Comment 4 Gyuyoung Kim 2012-10-19 08:27:44 PDT 
Comment on attachment 169622 [details]
Patch

Attachment 169622 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14462469
Comment 5 Jinwoo Song 2012-10-19 08:40:44 PDT 
Build is okay in my local pc, but failed in ews.

Linking CXX executable ../../bin/test_ewk2_view
CMakeFiles/test_ewk2_view.dir/UIProcess/API/efl/tests/test_ewk2_view.cpp.o: In function `EWK2UnitTestBase_ewk_view_scale_Test::TestBody()':
test_ewk2_view.cpp:(.text+0xc227): undefined reference to `ewk_view_scale_set'
test_ewk2_view.cpp:(.text+0xc456): undefined reference to `ewk_view_scale_set'
test_ewk2_view.cpp:(.text+0xc792): undefined reference to `ewk_view_scale_set'
collect2: ld returned 1 exit status
Comment 6 Jinwoo Song 2012-10-19 21:38:46 PDT 
The build is failed because the ewk_view_scale_set() is not exported. I think it is a bug and will be handled in https://bugs.webkit.org/show_bug.cgi?id=99902.
Comment 7 Jinwoo Song 2012-10-19 21:47:43 PDT 
Created attachment 169754 [details]
rebased patch
Comment 8 Gyuyoung Kim 2012-10-19 21:51:02 PDT 
Comment on attachment 169754 [details]
rebased patch

Attachment 169754 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14473241
Comment 9 Jinwoo Song 2012-10-19 22:15:06 PDT 
Created attachment 169755 [details]
rebased patch
Comment 10 WebKit Review Bot 2012-10-19 22:38:01 PDT 
Comment on attachment 169755 [details]
rebased patch

Clearing flags on attachment: 169755

Committed r131978: <http://trac.webkit.org/changeset/131978>
Comment 11 WebKit Review Bot 2012-10-19 22:38:06 PDT 
All reviewed patches have been landed.  Closing bug.