Bug 99804 – Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dongwoo Joshua Im (dwim)]

Regarding the discussion with jchaffraix on bug https://bugs.webkit.org/show_bug.cgi?id=99439,
I'd like to rename the flag ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT.

Under ENABLE_CSS3_TEXT flag, there could be implemented not only about text decoration,
but text alignment related features - such as text-align-last, and text-justify.

[Dongwoo Joshua Im (dwim)]

Created attachment 169549 [details]
Patch

[WebKit Review Bot]

Attachment 169549 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dongwoo Joshua Im (dwim)]

Style error of the first patch is not related with this bug.

This error will be fixed by https://bugs.webkit.org/show_bug.cgi?id=99807.

[Dongwoo Joshua Im (dwim)]

Created attachment 169559 [details]
Patch

[WebKit Review Bot]

Attachment 169559 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dongwoo Joshua Im (dwim)]

(In reply to comment #5)
> Attachment 169559 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
> LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
> Total errors found: 1 in 41 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Hmm.. same error again, although I've already fixed by another bug...

[Dongwoo Joshua Im (dwim)]

Created attachment 169571 [details]
Patch

[WebKit Review Bot]

Attachment 169571 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dongwoo Joshua Im (dwim)]

(In reply to comment #8)
> Attachment 169571 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
> LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
> Total errors found: 1 in 41 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

This style error is not about this patch itself.
So,... I will forget about this.

[Bruno Abinader (history only)]

Interesting, I've applied your patch locally and then ran 'check-webkit-style' which shows 0 errors. Is this an issue from the style build bot itself?

[Julien Chaffraix]

Comment on attachment 169571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169571&action=review

> Interesting, I've applied your patch locally and then ran 'check-webkit-style' which shows 0 errors. Is this an issue from the style build bot itself?

Linting errors are usually resolved fast as they turn the bots red so the patch probably hit a bad revision. Note that you can check linting errors with new-run-webkit-tests --lint-test-files (which is run as part of check-webkit-style).

> LayoutTests/platform/qt-mac/TestExpectations:5808
> +# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
>  webkit.org/b/58491 fast/css3-text-decoration

The error is line 1521 per the style bot so it's unrelated as you only touching around line 5808.

[WebKit Review Bot]

Comment on attachment 169571 [details]
Patch

Clearing flags on attachment: 169571

Committed r131925: <http://trac.webkit.org/changeset/131925>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.