Bug 99735 - Add String version of visitedLinkHash() to properly handle 8-bit URL Strings.
Summary: Add String version of visitedLinkHash() to properly handle 8-bit URL Strings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 100008
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-18 10:51 PDT by Michael Saboff
Modified: 2012-10-22 14:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2012-10-18 10:57 PDT, Michael Saboff 		peter+ews: commit-queue-
Details | Formatted Diff | Diff
Updated patch with speculative fix for chromium platform (5.94 KB, patch)
2012-10-19 10:24 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-18 10:51:51 PDT 
By adding a String version of visitedLinkHash() we can eliminate up converting 8-bit URL Strings to 16-bits.
Comment 1 Michael Saboff 2012-10-18 10:57:03 PDT 
Created attachment 169437 [details]
Patch
Comment 2 Peter Beverloo (cr-android ews) 2012-10-18 11:18:39 PDT 
Comment on attachment 169437 [details]
Patch

Attachment 169437 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14461097
Comment 3 WebKit Review Bot 2012-10-18 11:24:24 PDT 
Comment on attachment 169437 [details]
Patch

Attachment 169437 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14406032
Comment 4 Michael Saboff 2012-10-19 10:24:46 PDT 
Created attachment 169645 [details]
Updated patch with speculative fix for chromium platform
Comment 5 WebKit Review Bot 2012-10-19 16:21:47 PDT 
Comment on attachment 169645 [details]
Updated patch with speculative fix for chromium platform

Clearing flags on attachment: 169645

Committed r131955: <http://trac.webkit.org/changeset/131955>
Comment 6 WebKit Review Bot 2012-10-19 16:21:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2012-10-19 17:24:55 PDT 
Comment on attachment 169645 [details]
Updated patch with speculative fix for chromium platform

View in context: https://bugs.webkit.org/attachment.cgi?id=169645&action=review

> Source/WebCore/platform/chromium/LinkHashChromium.cpp:56
> +    return (url.characters(), url.length()); 

This can’t be right. It’s a comma expression that will return the length.
Comment 8 Michael Saboff 2012-10-22 09:11:31 PDT 
Need to update the chromium platform part of the change.
Comment 9 Michael Saboff 2012-10-22 14:09:21 PDT 
Change set r132116: <http://trac.webkit.org/changeset/132116> to https://bugs.webkit.org/show_bug.cgi?id=100008 landed, fixing the chromium change.