WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100008
r131955
is has improper function call in LinkHashChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=100008
Summary
r131955 is has improper function call in LinkHashChromium.cpp
Michael Saboff
Reported
2012-10-22 09:23:51 PDT
Change set
r131955
: <
http://trac.webkit.org/changeset/131955
> adds the following to LinkHashChromium.cpp: LinkHash visitedLinkHash(const String& url) { return (url.characters(), url.length()); } The return should really be: return visitedLinkHash(url.characters(), url.length());
Attachments
Patch
(1.42 KB, patch)
2012-10-22 09:25 PDT
,
Michael Saboff
ap
: review+
ap
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2012-10-22 09:25:37 PDT
Created
attachment 169924
[details]
Patch
Alexey Proskuryakov
Comment 2
2012-10-22 11:10:27 PDT
Comment on
attachment 169924
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=169924&action=review
Wow. Ideally, this should have a regression test, but I appreciate that this needs to be fixed quickly, and you probably don't have a way to easily test with Chromium.
> Source/WebCore/ChangeLog:13 > + * xml/parser/MarkupTokenBase.h:
No?
Michael Saboff
Comment 3
2012-10-22 11:58:22 PDT
Committed
r132116
: <
http://trac.webkit.org/changeset/132116
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug