Bug 100008 - r131955 is has improper function call in LinkHashChromium.cpp
Summary: r131955 is has improper function call in LinkHashChromium.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 99735
  Show dependency tree / graph
 
Reported: 2012-10-22 09:23 PDT by Michael Saboff
Modified: 2012-10-22 11:58 PDT (History)
0 users

See Also:

Attachments
Patch (1.42 KB, patch)
2012-10-22 09:25 PDT, Michael Saboff 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-22 09:23:51 PDT 
Change set r131955: <http://trac.webkit.org/changeset/131955> adds the following to LinkHashChromium.cpp:

LinkHash visitedLinkHash(const String& url)
{
    return (url.characters(), url.length());
}

The return should really be:
    return visitedLinkHash(url.characters(), url.length());
Comment 1 Michael Saboff 2012-10-22 09:25:37 PDT 
Created attachment 169924 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-10-22 11:10:27 PDT 
Comment on attachment 169924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169924&action=review

Wow. 

Ideally, this should have a regression test, but I appreciate that this needs to be fixed quickly, and you probably don't have a way to easily test with Chromium.

> Source/WebCore/ChangeLog:13
> +        * xml/parser/MarkupTokenBase.h:

No?
Comment 3 Michael Saboff 2012-10-22 11:58:22 PDT 
Committed r132116: <http://trac.webkit.org/changeset/132116>