Bug 99650 - Do not snap caret repaint rect and restore baseline special case for replaced elements
Summary: Do not snap caret repaint rect and restore baseline special case for replaced...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 16:04 PDT by Emil A Eklund
Modified: 2012-10-18 14:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (28.34 KB, patch)
2012-10-17 16:17 PDT, Emil A Eklund 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-10-17 16:04:41 PDT 
In bug 99376 (r131503) I removed the special case handling of baselines for replaced elements. This had some undesirable side effects, specifically for absolutely positioned replaced elements. 

This patch restores the special handling for replaced elements and instead tries to solve the caret repaint issue by not using the SnapOffsetForTransforms flag when computing the abs quad for the caret repaint rect.
Comment 1 Emil A Eklund 2012-10-17 16:17:39 PDT 
Created attachment 169285 [details]
Patch
Comment 2 Emil A Eklund 2012-10-17 17:05:07 PDT 
Comment on attachment 169285 [details]
Patch

DNR
Comment 3 Eric Seidel (no email) 2012-10-17 17:10:34 PDT 
If this is do-no-resuscitate, does that mean it should be closed WONTFIX?  Or did I misunderstand your acronym?
Comment 4 Eric Seidel (no email) 2012-10-17 17:11:13 PDT 
Oh, maybe you meant "Do Not Review".  I guess I've spent too much time around medical professionals. :)
Comment 5 Emil A Eklund 2012-10-17 17:21:22 PDT 
"Do Not Review" for now :) If it changes to "Do Not Resuscitate" I'll close the bug as appropriate.
Comment 6 WebKit Review Bot 2012-10-17 18:14:07 PDT 
Comment on attachment 169285 [details]
Patch

Attachment 169285 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14384775

New failing tests:
fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html
Comment 7 Emil A Eklund 2012-10-18 14:21:41 PDT 
Upgrading to "Do No Resuscitate".
Comment 8 Eric Seidel (no email) 2012-10-18 14:56:25 PDT 
:)