RESOLVED FIXED 99376
Remove special-case flooring of baselinePosition for replaced elements in InlineFlowBox::placeBoxesInBlockDirection 
https://bugs.webkit.org/show_bug.cgi?id=99376
Summary Remove special-case flooring of baselinePosition for replaced elements in Inl...
Emil A Eklund
Reported 2012-10-15 15:54:35 PDT
In r122769 (bug 91410) we added a special-case handling for replaced elements in InlineFlowBox::placeBoxesInBlockDirection to work around positioning issues in a couple of svg tests. This was needed to compensate for a workaround in the table painting code that was fixed in r131358 (bug 99364). As such the special-case handling for replaced elements is no longer needed in InlineFlowBox::placeBoxesInBlockDirection. Furthermore this caused problems with the caret positioning in come cases.
Attachments
Patch (15.39 KB, patch)
2012-10-16 10:33 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (15.40 KB, patch)
2012-10-16 10:46 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-10-16 10:33:34 PDT
Created attachment 168966 [details] Patch
Emil A Eklund
Comment 2 2012-10-16 10:46:57 PDT
Created attachment 168970 [details] Patch
WebKit Review Bot
Comment 3 2012-10-16 14:00:53 PDT
Comment on attachment 168970 [details] Patch Rejecting attachment 168970 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ls/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 MediaStream API: Add the chromium API for RTCDataChannel When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14384310
Emil A Eklund
Comment 4 2012-10-16 14:02:48 PDT
(In reply to comment #3) > CONFLICT (content): Merge conflict in Tools/ChangeLog > Failed to merge in the changes. How is this even possible? That file is not included in the patch and thus by definition cannot conflict.
Emil A Eklund
Comment 5 2012-10-16 14:03:45 PDT
Comment on attachment 168970 [details] Patch trying again as the commit queue seems to be very confused
Emil A Eklund
Comment 6 2012-10-16 14:09:31 PDT
Filed bug 99507 for the commit queue problem.
WebKit Review Bot
Comment 7 2012-10-16 14:32:42 PDT
Comment on attachment 168970 [details] Patch Clearing flags on attachment: 168970 Committed r131503: <http://trac.webkit.org/changeset/131503>
WebKit Review Bot
Comment 8 2012-10-16 14:32:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.