Bug 99376 - Remove special-case flooring of baselinePosition for replaced elements in InlineFlowBox::placeBoxesInBlockDirection
Summary: Remove special-case flooring of baselinePosition for replaced elements in Inl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on: 91410 99364
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-15 15:54 PDT by Emil A Eklund
Modified: 2012-10-16 14:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.39 KB, patch)
2012-10-16 10:33 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (15.40 KB, patch)
2012-10-16 10:46 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-10-15 15:54:35 PDT 
In r122769 (bug 91410) we added a special-case handling for replaced elements in InlineFlowBox::placeBoxesInBlockDirection to work around positioning issues in a couple of svg tests. This was needed to compensate for a workaround in the table painting code that was fixed in r131358 (bug 99364). As such the special-case handling for replaced elements is no longer needed in InlineFlowBox::placeBoxesInBlockDirection. Furthermore this caused problems with the caret positioning in come cases.
Comment 1 Emil A Eklund 2012-10-16 10:33:34 PDT 
Created attachment 168966 [details]
Patch
Comment 2 Emil A Eklund 2012-10-16 10:46:57 PDT 
Created attachment 168970 [details]
Patch
Comment 3 WebKit Review Bot 2012-10-16 14:00:53 PDT 
Comment on attachment 168970 [details]
Patch

Rejecting attachment 168970 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ls/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 MediaStream API: Add the chromium API for RTCDataChannel

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14384310
Comment 4 Emil A Eklund 2012-10-16 14:02:48 PDT 
(In reply to comment #3)
> CONFLICT (content): Merge conflict in Tools/ChangeLog
> Failed to merge in the changes.

How is this even possible? That file is not included in the patch and thus by definition cannot conflict.
Comment 5 Emil A Eklund 2012-10-16 14:03:45 PDT 
Comment on attachment 168970 [details]
Patch

trying again as the commit queue seems to be very confused
Comment 6 Emil A Eklund 2012-10-16 14:09:31 PDT 
Filed bug 99507 for the commit queue problem.
Comment 7 WebKit Review Bot 2012-10-16 14:32:42 PDT 
Comment on attachment 168970 [details]
Patch

Clearing flags on attachment: 168970

Committed r131503: <http://trac.webkit.org/changeset/131503>
Comment 8 WebKit Review Bot 2012-10-16 14:32:46 PDT 
All reviewed patches have been landed.  Closing bug.