Bug 99558 - [gyp] fix bundle resources for DumpRenderTree on mac
Summary: [gyp] fix bundle resources for DumpRenderTree on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 99023
  Show dependency tree / graph
 
Reported: 2012-10-17 00:38 PDT by jochen
Modified: 2012-10-17 09:55 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2012-10-17 00:40 PDT, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-10-17 00:38:53 PDT 
[gyp] fix bundle resources for DumpRenderTree on mac
Comment 1 jochen 2012-10-17 00:40:39 PDT 
Created attachment 169108 [details]
Patch
Comment 2 jochen 2012-10-17 00:42:36 PDT 
I tested that this also gets the resources into Content Shell.app, but not into Chrome.app
Comment 3 Adam Barth 2012-10-17 08:45:13 PDT 
Comment on attachment 169108 [details]
Patch

This looks reasonable to me.  Should we have a build step somewhere that checks that we don't leak these resources into Chrome.app?  I guess Chrome.app shouldn't depend on TestRunner_resources...

Ideally thakis and/or tony^work would comment before we land this patch.
Comment 4 Nico Weber 2012-10-17 09:46:03 PDT 
Comment on attachment 169108 [details]
Patch

I think this is fine.

Another possible approach would be do have a gypi file with the mac_bundle_resources block and just include that into the targets that need them, but if chrome ended up depending on TestRunner_resources that'd be bad anyway.
Comment 5 WebKit Review Bot 2012-10-17 09:55:08 PDT 
Comment on attachment 169108 [details]
Patch

Clearing flags on attachment: 169108

Committed r131613: <http://trac.webkit.org/changeset/131613>
Comment 6 WebKit Review Bot 2012-10-17 09:55:12 PDT 
All reviewed patches have been landed.  Closing bug.