Create a separate gyp target for dependencies of DumpRenderTree
Created attachment 168195 [details] Patch
Dirk or Adam, could one of you review this patch? Thanks
This is more in Tony or Dirk's area of expertise.
Comment on attachment 168195 [details] Patch Can we merge DumpRenderTree_helpers into the TestRunner target? If not, I think something like TestRunner_resources would be more descriptive since content_shell will be depending on this. Maybe LayoutTest_resources?
I agree that something like _resources or _support would probably be a better name than _helpers.
Created attachment 168392 [details] Patch
Comment on attachment 168392 [details] Patch TestRunner_resources it is
Comment on attachment 168392 [details] Patch Clearing flags on attachment: 168392 Committed r131173: <http://trac.webkit.org/changeset/131173>
All reviewed patches have been landed. Closing bug.
This seems like it broke the Debug DRT for Chromium. It now always crashes on startup with the below errors. This happens because the DumpRenderTree.app bundle is missing all the nested resources that should be inside like the ahem font, missingImage.png, textAreaResizeCorner.png and the WebkitWeightWatcher fonts. You can see they're missing by doing: ls /Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources ... I printed these out, we don't actually log the errors even though we should ... "Error Domain=com.apple.coretext Code=-1 \"The operation couldn\U2019t be completed. (com.apple.coretext error -1 - Could not register the font file 'file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher700.ttf')\" UserInfo=0x69c6d470 {CTFailedFontFileURL=file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher700.ttf, NSDescription=Could not register the font file 'file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher700.ttf'}", "Error Domain=com.apple.coretext Code=-1 \"The operation couldn\U2019t be completed. (com.apple.coretext error -1 - Could not register the font file 'file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher800.ttf')\" UserInfo=0x69c6cb70 {CTFailedFontFileURL=file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher800.ttf, NSDescription=Could not register the font file 'file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher800.ttf'}", "Error Domain=com.apple.coretext Code=-1 \"The operation couldn\U2019t be completed. (com.apple.coretext error -1 - Could not register the font file 'file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher900.ttf')\" UserInfo=0x69c6d6a0 {CTFailedFontFileURL=file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher900.ttf, NSDescription=Could not register the font file 'file://localhost/Volumes/Checkouts/chrome1/src/out/Debug/DumpRenderTree.app/Contents/Resources/WebKitWeightWatcher900.ttf'}" ) [3100:-1409166656:2220578234950:FATAL:platform_support_mac.mm(152)] Fail to activate fonts. Backtrace: 0 DumpRenderTree 0x00f1f57f base::debug::StackTrace::StackTrace() + 63 1 DumpRenderTree 0x00f1f51b base::debug::StackTrace::StackTrace() + 43 2 DumpRenderTree 0x00f6ed6c logging::LogMessage::~LogMessage() + 76 3 DumpRenderTree 0x00f6d85b logging::LogMessage::~LogMessage() + 43 4 DumpRenderTree 0x041738b2 webkit_support::AfterInitialize(bool) + 1746 5 DumpRenderTree 0x0417f714 (anonymous namespace)::SetUpTestEnvironmentImpl(bool, WebKit::Platform*) + 260 6 DumpRenderTree 0x0417f53b webkit_support::SetUpTestEnvironment(WebKit::Platform*) + 59 7 DumpRenderTree 0x000e65ef WebKitSupportTestEnvironment::WebKitSupportTestEnvironment() + 111 8 DumpRenderTree 0x000e437b WebKitSupportTestEnvironment::WebKitSupportTestEnvironment() + 43 9 DumpRenderTree 0x000e3031 main + 65 10 DumpRenderTree 0x000e0035 start + 53 Trace/BPT trap: 5
Comment on attachment 168392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168392&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:135 > + 'mac_bundle_resources': [ I'm not sure if this works; mac_bundle_resources aren't always pushed down to things depending on it. See http://crbug.com/137588 for example. Have you tested if DRT still works after a clobber build (killing just DRT.app and rebuilding it should be enough) with this?
Comment on attachment 168392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168392&action=review >> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:135 >> + 'mac_bundle_resources': [ > > I'm not sure if this works; mac_bundle_resources aren't always pushed down to things depending on it. See http://crbug.com/137588 for example. Have you tested if DRT still works after a clobber build (killing just DRT.app and rebuilding it should be enough) with this? I'll try tomorrow. From the bug, I guess moving this into an all_dependent_settings section will fix it.
(In reply to comment #11) > (From update of attachment 168392 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168392&action=review > > > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:135 > > + 'mac_bundle_resources': [ > > I'm not sure if this works; mac_bundle_resources aren't always pushed down to things depending on it. See http://crbug.com/137588 for example. Have you tested if DRT still works after a clobber build (killing just DRT.app and rebuilding it should be enough) with this? Indeed, rolling back change and Chromium change 161832 fixes the broken DRT packaging.