Bug 99495 - html5-full-render.html test uses substring but meant substr
Summary: html5-full-render.html test uses substring but meant substr
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
Depends on:
Blocks: 99657
  Show dependency treegraph
Reported: 2012-10-16 13:25 PDT by Elliott Sprehn
Modified: 2012-10-17 16:49 PDT (History)
6 users (show)

See Also:

Patch (1.56 KB, patch)
2012-10-16 13:26 PDT, Elliott Sprehn
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2012-10-16 13:25:19 PDT
html5-full-render.html test uses substring but meant substr
Comment 1 Elliott Sprehn 2012-10-16 13:26:19 PDT
Created attachment 169010 [details]
Comment 2 Elliott Sprehn 2012-10-16 23:30:45 PDT
For context see: https://bugs.webkit.org/show_bug.cgi?id=95117#c59
Comment 3 Adam Barth 2012-10-16 23:32:07 PDT
Comment on attachment 169010 [details]

Really Eric should review this patch, but Elliott asked me to look at it and I think Eric is asleep.
Comment 4 Eric Seidel (no email) 2012-10-16 23:34:04 PDT
It looks fantastic to me.   Aside from teh fact that JS has braindead apis.
Comment 5 Eric Seidel (no email) 2012-10-16 23:34:42 PDT
CCing folks who might see the perf bump and be surprised. :)
Comment 6 Elliott Sprehn 2012-10-16 23:42:59 PDT
This reduces the size of the HTML loaded in the test dramatically from 33.5m to 6.5m chars (and subsequently means tens of thousands of fewer DOM nodes) which should create a pretty big "perf win" in the graphs.
Comment 7 WebKit Review Bot 2012-10-16 23:50:50 PDT
Comment on attachment 169010 [details]

Clearing flags on attachment: 169010

Committed r131553: <http://trac.webkit.org/changeset/131553>
Comment 8 WebKit Review Bot 2012-10-16 23:50:54 PDT
All reviewed patches have been landed.  Closing bug.