Bug 99485 – [EFL][WK2][AC] Url bar should not be covered by the web view

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Yael]

When accelerated compositing is in use, the web view and its surface are not positioned correctly.
A patch is coming.

[Yael]

Created attachment 168992 [details]
Patch

[Viatcheslav Ostapenko]

Comment on attachment 168992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168992&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:688
> +        needsNewSurface = priv->evasGlSurface;

Here flag is set under USE(COORDINATED_GRAPHICS) condition.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:707
> +    if (needsNewSurface) {

And here it is used under USE(ACCELERATED_COMPOSITING) .
I would move assignment out of USE(COORDINATED_GRAPHICS) at least.

[Yael]

(In reply to comment #2)
> (From update of attachment 168992 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168992&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:688
> > +        needsNewSurface = priv->evasGlSurface;
> 
> Here flag is set under USE(COORDINATED_GRAPHICS) condition.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:707
> > +    if (needsNewSurface) {
> 
> And here it is used under USE(ACCELERATED_COMPOSITING) .
> I would move assignment out of USE(COORDINATED_GRAPHICS) at least.

I kept the flags as they are now. IMO, we should stick to one flag throughout the code, but I don't think that cleaning out the flags should be part of this patch.

[Yael]

Created https://bugs.webkit.org/show_bug.cgi?id=99503 to fix the flags.

[Yael]

Created attachment 169025 [details]
Patch

Update based on comment #2.

[Laszlo Gombos]

Comment on attachment 169025 [details]
Patch

LGTM, r=me.

[WebKit Review Bot]

Comment on attachment 169025 [details]
Patch

Clearing flags on attachment: 169025

Committed r131543: <http://trac.webkit.org/changeset/131543>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.