WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
99503
[EFL][WK2] Consolidate the AC related flags in EFL code
https://bugs.webkit.org/show_bug.cgi?id=99503
Summary
[EFL][WK2] Consolidate the AC related flags in EFL code
Yael
Reported
2012-10-16 14:02:49 PDT
We may not want to change common code, but in EFL port, we should be using only one flag for accelerated compositing. I propose to use WTF_USE_COORDINATED_GRAPHICS instead of the various flags we have.
Attachments
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2012-10-16 16:20:53 PDT
If eliminating build flags are not possible we should at least explicitly mark unsupported combination of flags. As an example if USE_COORDINATED_GRAPHICS is set but ACCELERATED_COMPOSITING is not set for the EFL port the build should explicitly fail (e.g. with an #error msg).
YoungTaeck Song
Comment 2
2012-10-16 18:29:02 PDT
I think it's good to follow Laszlo's suggestion. We inherited Qt's COORDINATED_GRAPHICS. Qt use ACCELERATED_COMPOSITING, TEXTURE_MAPPER, and COORDINATED_GRAPHICS flags by default. COORDINATED_GRAPHICS internally use TEXTURE_MAPPER by default. So another flags like TEXTURE_MAPPER also have to be enable for using COORDINATED_GRAPHICS.
Michael Catanzaro
Comment 3
2017-03-11 10:41:47 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug