Bug 99503 - [EFL][WK2] Consolidate the AC related flags in EFL code
Summary: [EFL][WK2] Consolidate the AC related flags in EFL code
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 14:02 PDT by Yael
Modified: 2017-03-11 10:41 PST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2012-10-16 14:02:49 PDT 
We may not want to change common code, but in EFL port, we should be using only one flag for accelerated compositing.
I propose to use WTF_USE_COORDINATED_GRAPHICS instead of the various flags we have.
Comment 1 Laszlo Gombos 2012-10-16 16:20:53 PDT 
If eliminating build flags are not possible we should at least explicitly mark unsupported combination of flags.

As an example if USE_COORDINATED_GRAPHICS is set but ACCELERATED_COMPOSITING is not set for the EFL port the build should explicitly fail (e.g. with an #error msg).
Comment 2 YoungTaeck Song 2012-10-16 18:29:02 PDT 
I think it's good to follow Laszlo's suggestion.
We inherited Qt's COORDINATED_GRAPHICS. 
Qt use ACCELERATED_COMPOSITING, TEXTURE_MAPPER, and COORDINATED_GRAPHICS flags by default.
COORDINATED_GRAPHICS internally use TEXTURE_MAPPER by default. So another flags like TEXTURE_MAPPER also have to be enable for using COORDINATED_GRAPHICS.
Comment 3 Michael Catanzaro 2017-03-11 10:41:47 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.