Bug 99319 - Web Inspector: Update CodeMirror to v3
Summary: Web Inspector: Update CodeMirror to v3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL: http://codemirror.net
Keywords:
Depends on:
Blocks: 94056 94062 94118
  Show dependency tree / graph
 
Reported: 2012-10-15 06:27 PDT by Jan Keromnes
Modified: 2012-11-08 07:42 PST (History)
12 users (show)

See Also:

Attachments
Patch (294.62 KB, patch)
2012-11-01 09:23 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2012-11-08 07:09 PST, Jan Keromnes 		pfeldman: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Keromnes 2012-10-15 06:27:20 PDT 
CodeMirror has a new version coming up, that should not only show still better performance, but it should also make the implementation of #94056 and #94062 fairly straightforward. As soon as v3 is stable enough, we should migrate our current CodeMirror code base to the new version.
Comment 1 Pavel Feldman 2012-11-01 09:23:46 PDT 
Created attachment 171873 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-01 10:05:45 PDT 
Comment on attachment 171873 [details]
Patch

Clearing flags on attachment: 171873

Committed r133189: <http://trac.webkit.org/changeset/133189>
Comment 3 WebKit Review Bot 2012-11-01 10:05:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Jan Keromnes 2012-11-08 07:09:36 PST 
Reopening to attach new patch.
Comment 5 Jan Keromnes 2012-11-08 07:09:44 PST 
Created attachment 173038 [details]
Patch
Comment 6 Pavel Feldman 2012-11-08 07:39:33 PST 
Comment on attachment 173038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57
> -    CodeMirror.on(this._codeMirror, "change", this._change.bind(this));

Why this was wrong? It seems to work for me.
Comment 7 Vsevolod Vlasov 2012-11-08 07:42:54 PST 
Please create a new bug for each patch.