RESOLVED FIXED 99022
[Blackberry] makes NavigatorContentUtils work 
https://bugs.webkit.org/show_bug.cgi?id=99022
Summary [Blackberry] makes NavigatorContentUtils work
Chris.Guan
Reported 2012-10-11 04:28:09 PDT
Because r126735 renamed RegisterProtocolHandler API to NavigatorContentUtils and r122810 added RegisterProtocolHandlerClient to the Modules/protocolhandler, we need sync up code on blackberry to make this feature work again.
Attachments
Patch (9.38 KB, patch)
2012-10-11 04:50 PDT, Chris.Guan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris.Guan
Comment 1 2012-10-11 04:50:18 PDT
Created attachment 168193 [details] Patch
Rob Buis
Comment 2 2012-10-11 04:57:53 PDT
Comment on attachment 168193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review > Source/WebKit/PlatformBlackBerry.cmake:-120 > - blackberry/WebCoreSupport/RegisterProtocolHandlerClientBlackBerry.cpp Don't you need to remove RegisterProtocolHandlerClientBlackBerry in this patch?
Chris.Guan
Comment 3 2012-10-11 05:07:39 PDT
(In reply to comment #2) > (From update of attachment 168193 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review > > > Source/WebKit/PlatformBlackBerry.cmake:-120 > > - blackberry/WebCoreSupport/RegisterProtocolHandlerClientBlackBerry.cpp > > Don't you need to remove RegisterProtocolHandlerClientBlackBerry in this patch? I did not find this file in upstream repo, I think someone removed it.
Rob Buis
Comment 4 2012-10-11 05:15:35 PDT
Comment on attachment 168193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review LGTM. > Source/WebKit/PlatformBlackBerry.cmake:65 > +IF (ENABLE_NAVIGATOR_CONTENT_UTILS) Do you still need the ENABLE_CUSTOM_SCHEME_HANDLER part?
Chris.Guan
Comment 5 2012-10-11 05:22:40 PDT
(In reply to comment #4) > (From update of attachment 168193 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review > > LGTM. > > > Source/WebKit/PlatformBlackBerry.cmake:65 > > +IF (ENABLE_NAVIGATOR_CONTENT_UTILS) > > Do you still need the ENABLE_CUSTOM_SCHEME_HANDLER part? yes, we need it now, CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER. see https://bugs.webkit.org/show_bug.cgi?id=93081.
WebKit Review Bot
Comment 6 2012-10-11 07:16:50 PDT
Comment on attachment 168193 [details] Patch Clearing flags on attachment: 168193 Committed r131056: <http://trac.webkit.org/changeset/131056>
WebKit Review Bot
Comment 7 2012-10-11 07:16:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.