Bug 99022 - [Blackberry] makes NavigatorContentUtils work
Summary: [Blackberry] makes NavigatorContentUtils work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 04:28 PDT by Chris.Guan
Modified: 2012-10-11 07:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.38 KB, patch)
2012-10-11 04:50 PDT, Chris.Guan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris.Guan 2012-10-11 04:28:09 PDT 
Because r126735 renamed RegisterProtocolHandler API to NavigatorContentUtils and r122810 added RegisterProtocolHandlerClient to the Modules/protocolhandler, we need sync up code on blackberry to make this feature work again.
Comment 1 Chris.Guan 2012-10-11 04:50:18 PDT 
Created attachment 168193 [details]
Patch
Comment 2 Rob Buis 2012-10-11 04:57:53 PDT 
Comment on attachment 168193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review

> Source/WebKit/PlatformBlackBerry.cmake:-120
> -    blackberry/WebCoreSupport/RegisterProtocolHandlerClientBlackBerry.cpp

Don't you need to remove RegisterProtocolHandlerClientBlackBerry in this patch?
Comment 3 Chris.Guan 2012-10-11 05:07:39 PDT 
(In reply to comment #2)
> (From update of attachment 168193 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review
> 
> > Source/WebKit/PlatformBlackBerry.cmake:-120
> > -    blackberry/WebCoreSupport/RegisterProtocolHandlerClientBlackBerry.cpp
> 
> Don't you need to remove RegisterProtocolHandlerClientBlackBerry in this patch?

I did not find this file in upstream repo, I think someone removed it.
Comment 4 Rob Buis 2012-10-11 05:15:35 PDT 
Comment on attachment 168193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review

LGTM.

> Source/WebKit/PlatformBlackBerry.cmake:65
> +IF (ENABLE_NAVIGATOR_CONTENT_UTILS)

Do you still need the ENABLE_CUSTOM_SCHEME_HANDLER part?
Comment 5 Chris.Guan 2012-10-11 05:22:40 PDT 
(In reply to comment #4)
> (From update of attachment 168193 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review
> 
> LGTM.
> 
> > Source/WebKit/PlatformBlackBerry.cmake:65
> > +IF (ENABLE_NAVIGATOR_CONTENT_UTILS)
> 
> Do you still need the ENABLE_CUSTOM_SCHEME_HANDLER part?

yes, we need it now, CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER. see https://bugs.webkit.org/show_bug.cgi?id=93081.
Comment 6 WebKit Review Bot 2012-10-11 07:16:50 PDT 
Comment on attachment 168193 [details]
Patch

Clearing flags on attachment: 168193

Committed r131056: <http://trac.webkit.org/changeset/131056>
Comment 7 WebKit Review Bot 2012-10-11 07:16:54 PDT 
All reviewed patches have been landed.  Closing bug.