Bug 93081 - CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
Summary: CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 92749
  Show dependency treegraph
 
Reported: 2012-08-03 02:09 PDT by Mikhail Pozdnyakov
Modified: 2012-08-07 01:34 PDT (History)
8 users (show)

See Also:


Attachments
patch (15.83 KB, patch)
2012-08-03 02:47 PDT, Mikhail Pozdnyakov
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch v2 (16.10 KB, patch)
2012-08-03 04:02 PDT, Mikhail Pozdnyakov
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
to be landed (16.00 KB, patch)
2012-08-07 00:02 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-08-03 02:09:41 PDT
Currently we have a CUSTOM_SCHEME_HANDLER completely independent from REGISTER_PROTOCOL_HANDLER flag.
This is bad for the following reasons:
1) Have ugly #if ENABLE(REGISTER_PROTOCOL_HANDLER) || ENABLE(CUSTOM_SCHEME_HANDLER) in many places
2) if CUSTOM_SCHEME_HANDLER and REGISTER_PROTOCOL_HANDLER is not set, the User has 
weird API which contains isProtocolHandlerRegistered and unregisterProtocolHandler but does not contain registerProtocolHandler.
Comment 1 Mikhail Pozdnyakov 2012-08-03 02:47:53 PDT
Created attachment 156302 [details]
patch
Comment 2 WebKit Review Bot 2012-08-03 03:13:51 PDT
Comment on attachment 156302 [details]
patch

Attachment 156302 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13421756
Comment 3 Mikhail Pozdnyakov 2012-08-03 04:02:26 PDT
Created attachment 156316 [details]
patch v2

Fix cr-linux bot failure.
Comment 4 Mikhail Pozdnyakov 2012-08-06 05:18:22 PDT
Could please anyone review it? Thanks
Comment 5 Adam Barth 2012-08-06 13:27:10 PDT
Comment on attachment 156316 [details]
patch v2

Ok.
Comment 6 WebKit Review Bot 2012-08-06 13:31:06 PDT
Comment on attachment 156316 [details]
patch v2

Rejecting attachment 156316 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rivate.h
patching file Source/WebKit/efl/ewk/ewk_view.cpp
Hunk #2 FAILED at 761.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13448278
Comment 7 Mikhail Pozdnyakov 2012-08-07 00:02:54 PDT
Created attachment 156882 [details]
to be landed
Comment 8 WebKit Review Bot 2012-08-07 01:34:09 PDT
Comment on attachment 156882 [details]
to be landed

Clearing flags on attachment: 156882

Committed r124866: <http://trac.webkit.org/changeset/124866>
Comment 9 WebKit Review Bot 2012-08-07 01:34:15 PDT
All reviewed patches have been landed.  Closing bug.