Currently we have a CUSTOM_SCHEME_HANDLER completely independent from REGISTER_PROTOCOL_HANDLER flag. This is bad for the following reasons: 1) Have ugly #if ENABLE(REGISTER_PROTOCOL_HANDLER) || ENABLE(CUSTOM_SCHEME_HANDLER) in many places 2) if CUSTOM_SCHEME_HANDLER and REGISTER_PROTOCOL_HANDLER is not set, the User has weird API which contains isProtocolHandlerRegistered and unregisterProtocolHandler but does not contain registerProtocolHandler.
Created attachment 156302 [details] patch
Comment on attachment 156302 [details] patch Attachment 156302 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13421756
Created attachment 156316 [details] patch v2 Fix cr-linux bot failure.
Could please anyone review it? Thanks
Comment on attachment 156316 [details] patch v2 Ok.
Comment on attachment 156316 [details] patch v2 Rejecting attachment 156316 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rivate.h patching file Source/WebKit/efl/ewk/ewk_view.cpp Hunk #2 FAILED at 761. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13448278
Created attachment 156882 [details] to be landed
Comment on attachment 156882 [details] to be landed Clearing flags on attachment: 156882 Committed r124866: <http://trac.webkit.org/changeset/124866>
All reviewed patches have been landed. Closing bug.